Add Scala-CLI, but do not remove Ammonite yet #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scala-CLI is the new command-line runner for the Scala language, intended to replace Ammonite.
The ODKFull image defines the COURSIER_CACHE environment variable to /tools/.coursier-cache, so Ammonite and Scala-CLI expect to be able to store their downloaded dependencies in there. If we run under a non-privileged user, we need to ensure that, if the directory does not exist, it is created and given to the odkuser. (If the directory already exists, it means a host directory has been explicitly bound to it, in which case permissions will already be correct, and we have nothing to do.)
Mention in the changelog that Scala users should start moving away from Ammonite towards Scala-CLI.
|
Merging without review (YOLO!) since the original PR (#1165) has already been reviewed and approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1165. It also adds Scala-CLI to ODKFull, but leaves Ammonite in place, with a deprecation notice warning users of its future complete removal (probably in ODK 1.7).
fixes #1161
partially addresses #1162