Add test for all_by_all_pairwise_similarity() in semsimian using custom IC map #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrshdhgd
approved these changes
Aug 21, 2024
|
You may want to lint it |
cmungall
reviewed
Aug 21, 2024
| raise AssertionError("SemanticSimilarityInterface not implemented") | ||
| entities = [VACUOLE, ENDOMEMBRANE_SYSTEM] | ||
|
|
||
| sim = (adapter.all_by_all_pairwise_similarity(entities, entities, predicates=self.predicates)) |
There was a problem hiding this comment.
not related to this PR but the way this test module uses object variables for constants is a little unusual
cmungall
reviewed
Aug 21, 2024
| sim = (adapter.all_by_all_pairwise_similarity(entities, entities, predicates=self.predicates)) | ||
|
|
||
| for s in sim: | ||
| if s is not None: |
There was a problem hiding this comment.
super pedantic: I much prefer doing an initial assert s is not None, then no need for the indented if/else clause.
cmungall
approved these changes
Aug 21, 2024
added 2 commits
August 21, 2024 12:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@caufieldjh @hrshdhgd