Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

value_set_names is None rather than () #707

Merged
merged 3 commits into from
Mar 11, 2024
Merged

value_set_names is None rather than () #707

merged 3 commits into from
Mar 11, 2024

Conversation

hrshdhgd
Copy link
Collaborator

@hrshdhgd hrshdhgd commented Mar 8, 2024 •
edited
Loading

Fixes #701

When value_set_names param was not provided, it was passed as an empty tuple since it accepts multiple arguments. This PR forces it to be None instead on ()

@hrshdhgd hrshdhgd requested a review from cmungall March 8, 2024 21:46
@cmungall cmungall merged commit c1257a8 into main Mar 11, 2024
6 checks passed
@hrshdhgd hrshdhgd deleted the issue-701 branch March 12, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in how vskit handles an empty list of arguments
2 participants
@hrshdhgd @cmungall