-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell support: config, action (to detect new) + get some typos fixed #671
Conversation
I approved the build and also invited you to the repo so this should not be necessary in future, thx! |
d77fdcf
to
5699eed
Compare
cool, thanks - accepted. new typos emerged since then, rebased, added an ignore on "infarctions" (not so common word) and reran. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
- Coverage 76.34% 75.89% -0.46%
==========================================
Files 256 256
Lines 29734 29734
==========================================
- Hits 22701 22567 -134
- Misses 7033 7167 +134 ☔ View full report in Codecov by Sentry. |
5699eed
to
66e56a6
Compare
I rebased, this introduced a new test file that fails spellchecks. I think in this scenario we want to exclude verbatim test examples like this |
I did before fixed up those
I can exclude them all -- I just wonder if that anyhow would effect tests -- that they would have corrected words while input files -- failed... let me redo that way and see if we hit such cases. Also I will fix a fresh typo in a notebook |
=== Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
66e56a6
to
63b471f
Compare
CI is green, so I guess ignoring the inputs, didn't cause some turmoil in the tests -- good |
No description provided.