Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell support: config, action (to detect new) + get some typos fixed #671

Merged
merged 7 commits into from
Jan 20, 2024

Conversation

yarikoptic
Copy link
Collaborator

No description provided.

@cmungall
Copy link
Collaborator

cmungall commented Nov 6, 2023

I approved the build and also invited you to the repo so this should not be necessary in future, thx!

@yarikoptic
Copy link
Collaborator Author

cool, thanks - accepted. new typos emerged since then, rebased, added an ignore on "infarctions" (not so common word) and reran.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (490a6ec) 76.34% compared to head (691607b) 75.89%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   76.34%   75.89%   -0.46%     
==========================================
  Files         256      256              
  Lines       29734    29734              
==========================================
- Hits        22701    22567     -134     
- Misses       7033     7167     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall
Copy link
Collaborator

I rebased, this introduced a new test file that fails spellchecks. I think in this scenario we want to exclude verbatim test examples like this

@yarikoptic
Copy link
Collaborator Author

I did before fixed up those

❯ git diff origin/main --stat -- ./tests/input
 tests/input/AMPK-Signaling.cx   |      2 +-
 tests/input/go-nucleus.owl      |      8 +-
 tests/input/ncbigene-1956.xml   | 635814 ++++++++++++++++++++++++++++++++
 tests/input/uniprot-P12345.json |   1898 +
 4 files changed, 637717 insertions(+), 5 deletions(-)

I can exclude them all -- I just wonder if that anyhow would effect tests -- that they would have corrected words while input files -- failed... let me redo that way and see if we hit such cases. Also I will fix a fresh typo in a notebook

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic
Copy link
Collaborator Author

CI is green, so I guess ignoring the inputs, didn't cause some turmoil in the tests -- good

@cmungall cmungall merged commit d139e99 into INCATools:main Jan 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants