Skip to content

Commit

Permalink
updated url parsing syntax
Browse files Browse the repository at this point in the history
  • Loading branch information
AustinWilloughby committed Aug 20, 2024
1 parent 42c5e17 commit ba0b8b0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
13 changes: 7 additions & 6 deletions src/jsonResponses.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,25 @@ const getUsers = (request, response) => {
respondJSON(request, response, 200, responseJSON);
};

const addUser = (request, response, body) => {
const addUser = (request, response) => {
const responseJSON = {
message: 'Name and age are both required.',
};

if (!body.name || !body.age) {
if (!request.body.name || !request.body.age) {
responseJSON.id = 'missingParams';
return respondJSON(request, response, 400, responseJSON);
}

let responseCode = 204;
if (!users[body.name]) {
const {name, age} = request.body;
if (!users[name]) {
responseCode = 201;
users[body.name] = {};
users[name] = {};
}

users[body.name].name = body.name;
users[body.name].age = body.age;
users[name].name = name;
users[name].age = age;

if (responseCode === 201) {
responseJSON.message = 'Created Successfully';
Expand Down
8 changes: 4 additions & 4 deletions src/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*/

const http = require('http');
const url = require('url');
const query = require('querystring');
const htmlHandler = require('./htmlResponses.js');
const jsonHandler = require('./jsonResponses.js');
Expand All @@ -28,8 +27,8 @@ const parseBody = (request, response, handler) => {

request.on('end', () => {
const bodyString = Buffer.concat(body).toString();
const bodyParams = query.parse(bodyString);
handler(request, response, bodyParams);
request.body = query.parse(bodyString);
handler(request, response);
});
};

Expand All @@ -50,7 +49,8 @@ const handleGet = (request, response, parsedUrl) => {
};

const onRequest = (request, response) => {
const parsedUrl = url.parse(request.url);
const protocol = request.connection.encrypted ? 'https' : 'http';
const parsedUrl = new URL(request.url, `${protocol}://${request.headers.host}`);

if (request.method === 'POST') {
handlePost(request, response, parsedUrl);
Expand Down

0 comments on commit ba0b8b0

Please sign in to comment.