Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Appeal type issue on search #2396

Merged
merged 2 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion api/search_indexes.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,12 @@ class EmergenciesIndex(indexes.Indexable, indexes.SearchIndex):
countries_id = indexes.MultiValueField(
null=True,
)
appeal_type = indexes.CharField(model_attr="appeals__get_atype_display", null=True)
appeals_id = indexes.MultiValueField(
null=True,
)
appeals_type = indexes.MultiValueField(
null=True,
)
crisis_categorization = indexes.CharField(model_attr="get_ifrc_severity_level_display", null=True)
iso3 = indexes.MultiValueField(null=True)
visibility = indexes.CharField(model_attr="get_visibility_display", null=True)
Expand All @@ -96,6 +101,12 @@ def prepare_countries_id(self, obj):
def prepare_iso3(self, obj):
return [country.iso3 for country in obj.countries.all() if country.iso3]

def prepare_appeals_id(self, obj):
return [appeal.id for appeal in obj.appeals.all()]

def prepare_appeals_type(self, obj):
return [appeal.get_atype_display() for appeal in obj.appeals.all()]

def index_queryset(self, using=None):
return self.get_model().objects.all()

Expand Down
7 changes: 6 additions & 1 deletion api/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2184,6 +2184,11 @@ class SearchMiniCountrySerializer(serializers.Serializer):
name = serializers.CharField()


class SearchMiniAppealSerializer(serializers.Serializer):
id = serializers.IntegerField()
atype = serializers.CharField()


class SearchEmergencySerializer(serializers.Serializer):
id = serializers.IntegerField()
name = serializers.CharField()
Expand All @@ -2195,7 +2200,7 @@ class SearchEmergencySerializer(serializers.Serializer):
# countries_id = serializers.ListField(child=serializers.IntegerField())
# iso3 = serializers.ListField(child=serializers.CharField())
severity_level_display = serializers.CharField()
appeal_type = serializers.CharField()
appeals = SearchMiniAppealSerializer(many=True)
score = serializers.FloatField()
severity_level = serializers.IntegerField()

Expand Down
2 changes: 1 addition & 1 deletion api/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ def get(self, request):
"score": data.score,
"countries": [{"id": id, "name": name} for id, name in zip(data.countries_id, data.countries)],
"severity_level_display": data.crisis_categorization,
"appeal_type": data.appeal_type,
"appeals": [{"id": id, "atype": atype} for id, atype in zip(data.appeals_id, data.appeals_type)],
"severity_level": data.severity_level,
}
for data in emergency_response[:50]
Expand Down
Loading