Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disclaimer about installation uninstalling IDAES #119

Merged
merged 1 commit into from
May 24, 2024

Conversation

dallan-keylogic
Copy link
Contributor

@dallan-keylogic dallan-keylogic commented May 23, 2024

Fixes #97

The behavior described in #97 was intentional but nonintuitive, a disclaimer has been added advising the user of that behavior and a workaround if they want their own version of IDAES.


Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--119.org.readthedocs.build/en/119/

@dallan-keylogic dallan-keylogic requested a review from dangunter May 23, 2024 17:50
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label May 23, 2024
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Robbybp Robbybp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also confusing to me when I installed the examples. Thanks for adding this.

@dallan-keylogic dallan-keylogic merged commit e5163e3 into IDAES:main May 24, 2024
9 checks passed
@dallan-keylogic dallan-keylogic deleted the readme-tweak branch May 24, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip install -r requirements-dev.txt uninstalls local installation of IDAES
3 participants