Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed custom ethercat plugins #98

Merged
merged 1 commit into from
Dec 20, 2023
Merged

removed custom ethercat plugins #98

merged 1 commit into from
Dec 20, 2023

Conversation

yguel
Copy link
Contributor

@yguel yguel commented Dec 20, 2023

No description provided.

@github-actions GitHub Actions
Copy link

Test Results

127 tests   - 134   105 ✔️  - 110   0s ⏱️ ±0s
  29 suites  -   56     22 💤  -   24 
  29 files    -   42       0 ❌ ±    0 

Results for commit b88345f. ± Comparison against base commit abde980.

This pull request removes 134 tests. 
ethercat_advantech_modules.TestLoadAdvantech_AMAX5051 ‑ load_ec_module
ethercat_advantech_modules.TestLoadAdvantech_AMAX5056 ‑ load_ec_module
ethercat_advantech_modules.copyright ‑ src/amax5051.cpp
ethercat_advantech_modules.copyright ‑ src/amax5056.cpp
ethercat_advantech_modules.copyright ‑ test/test_load_ec_modules.cpp
ethercat_advantech_modules.cppcheck ‑ src/amax5051.cpp
ethercat_advantech_modules.cppcheck ‑ src/amax5056.cpp
ethercat_advantech_modules.cppcheck ‑ test/test_load_ec_modules.cpp
ethercat_advantech_modules.cpplint ‑ /ros/src/ethercat_driver_ros2/ethercat_plugins/ethercat_advantech_modules/src/amax5051.cpp
ethercat_advantech_modules.cpplint ‑ /ros/src/ethercat_driver_ros2/ethercat_plugins/ethercat_advantech_modules/src/amax5056.cpp
…

mcbed
mcbed approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@mcbed mcbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@yguel yguel merged commit 396cb1a into main Dec 20, 2023
3 checks passed
@yguel yguel deleted the yguel-delete-modules branch December 20, 2023 14:18
yguel added a commit to yguel/ethercat_driver_ros2 that referenced this pull request Mar 1, 2024
@yguel @mcbed
removed custom ethercat plugins (ICube-Robotics#98)
5b41a11 
Co-authored-by: mcbed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcbed mcbed mcbed approved these changes

Assignees

@mcbed mcbed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yguel @mcbed