Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ipopt factory for use with SacessOptimizer #1533

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 2, 2024

... to forward the overall wall time limit to Ipopt.

Note: the Ipopt walltime limit is not supported by the current (outdated) Ubuntu Ipopt packages

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.85714% with 16 lines in your changes missing coverage. Please review.

Project coverage is 82.20%. Comparing base (20fd9de) to head (97126b0).

Files with missing lines Patch % Lines
pypesto/optimize/ess/sacess.py 28.57% 10 Missing ⚠️
pypesto/optimize/ess/ess.py 57.14% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1533      +/-   ##
===========================================
- Coverage    84.36%   82.20%   -2.16%     
===========================================
  Files          163      163              
  Lines        14034    14057      +23     
===========================================
- Hits         11840    11556     -284     
- Misses        2194     2501     +307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl marked this pull request as ready for review December 2, 2024 14:31
@dweindl dweindl self-assigned this Dec 6, 2024
@dweindl dweindl force-pushed the sacess_ipopt branch 2 times, most recently from 4a433e0 to 0c0e332 Compare December 9, 2024 09:51
... to forward the overall wall time limit to Ipopt.
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, needs a small adjustment. Requesting changes to prevent pushing into queue.

pypesto/optimize/ess/sacess.py Outdated Show resolved Hide resolved
@dweindl dweindl enabled auto-merge December 10, 2024 17:50
@dweindl dweindl disabled auto-merge December 19, 2024 20:05
@dweindl dweindl marked this pull request as draft December 19, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants