-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vignettes/58 #67
Vignettes/58 #67
Conversation
… frameworks and constraints, 3-classification example
…d added explanation about luz_model_sequential()
…aloader() in torch examples
…d its usage in vignettes
…n2poly() and be able inherit docs.
…m nn2poly. Added documentation, tests and examples. This introduces the notation `result$layer_i$output`
…n, denoting `layer_x$input` or `layer_x$output`. Updated affected tests and documentations plus some other minor improvements.
… polynomials by columns instead of rows.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 83.16% 79.93% -3.24%
==========================================
Files 16 16
Lines 606 648 +42
==========================================
+ Hits 504 518 +14
- Misses 102 130 +28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed a couple of NOTEs: detritus in temp dir and the "figure" thing (it seems that there was a specific test for this name after all, so... changed to "includes").
A couple of comments:
- Some examples are required for
add_constraints
andluz_model_sequential
. - I don't remember if we talked about maintaining the Rd for
eval_poly
or adding@noRd
instead.
And don't worry about the failing check in r-devel. It's an Rcpp issue and will be fixed with the next release in a few days.
Checks fixed thanks to the new version of Rcpp. |
…pace when using dependecies from Suggests.
Added missing examples for
We talked about maintaining it temporarily as it is used to define some of data in the vignettes. A warning about it being subject to change and not exported is mentioned in the details section of its documentation. |
This PR covers several topics that were related or appeared while updating and reviewing all the docs and vignettes. The main changes can be summarized as follows:
eval_poly()
x
argument tonewdata
eval_poly()
which closes Fix intercept (0
) check ineval_poly()
#63.nn2poly()
andpredict()
outputs to represent polynomials in columns instead of rows for consistency with other predict functions. This closes Switch columns by rows innn2poly()
andpredict()
outputs #66.nn2poly()
andpredict()
when usingkeep_layers=TRUE
, which closes Output format fornn2poly(keep_layers = TRUE)
andpredict()
. #64. Furthermore, choosing specific layers when predicting is now supported.torch
are now skipped due to an external fail in GitHub Actions Testing problems withtorch
in mac #65.