Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignettes/58 #67

Merged
merged 25 commits into from
Jan 15, 2024
Merged

Vignettes/58 #67

merged 25 commits into from
Jan 15, 2024

Conversation

moralapablo
Copy link
Member

This PR covers several topics that were related or appeared while updating and reviewing all the docs and vignettes. The main changes can be summarized as follows:

… frameworks and constraints, 3-classification example
…d added explanation about luz_model_sequential()
…m nn2poly. Added documentation, tests and examples. This introduces the notation `result$layer_i$output`
…n, denoting `layer_x$input` or `layer_x$output`. Updated affected tests and documentations plus some other minor improvements.
… polynomials by columns instead of rows.
@moralapablo moralapablo requested a review from Enchufa2 January 9, 2024 14:20
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6daded) 83.16% compared to head (20ba923) 79.93%.
Report is 1 commits behind head on master.

❗ Current head 20ba923 differs from pull request most recent head 269aee7. Consider uploading reports for the commit 269aee7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   83.16%   79.93%   -3.24%     
==========================================
  Files          16       16              
  Lines         606      648      +42     
==========================================
+ Hits          504      518      +14     
- Misses        102      130      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a couple of NOTEs: detritus in temp dir and the "figure" thing (it seems that there was a specific test for this name after all, so... changed to "includes").

A couple of comments:

  • Some examples are required for add_constraints and luz_model_sequential.
  • I don't remember if we talked about maintaining the Rd for eval_poly or adding @noRd instead.

And don't worry about the failing check in r-devel. It's an Rcpp issue and will be fixed with the next release in a few days.

@Enchufa2
Copy link
Member

Checks fixed thanks to the new version of Rcpp.

@moralapablo
Copy link
Member Author

moralapablo commented Jan 15, 2024

Added missing examples for add_constraints() and luz_sequential_model().

  • I don't remember if we talked about maintaining the Rd for eval_poly or adding @noRd instead.

We talked about maintaining it temporarily as it is used to define some of data in the vignettes. A warning about it being subject to change and not exported is mentioned in the details section of its documentation.

@Enchufa2 Enchufa2 merged commit d85da73 into master Jan 15, 2024
13 checks passed
@Enchufa2 Enchufa2 deleted the vignettes/58 branch January 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants