-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project - Andrea Rivera #98
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mucss-dataviz ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb job! Minor comments below.
--- | ||
|
||
```{r setup, include=FALSE} | ||
knitr::opts_chunk$set(out.width="200%", fig.align="center") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be 100%?
```{css text alignment} | ||
#| echo: false | ||
p {text-align: justify} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove this to keep the formatting of the rest of the web. I like it left-aligned better. ;-)
p {text-align: justify} | ||
``` | ||
|
||
## **Setting the stage** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please remove any additional formatting from titles (things like bold notation, italics...). To preserve a uniform style, titles should look as the CSS of the page tells them.
|
||
For this visualization, Georgia Lupi, author of the original graph, took her inspiration from musical scores and their elegant aesthetics, especially John Cage's source of fascinating contemporary scores. She visualized the evolution over time of the 6 prize categories, as colored musical scores along a skewed timeline. | ||
|
||
![*Nobels, no degrees* by Georgia Lupi for [La Lettura](https://www.flickr.com/photos/accurat/8249872482/in/album-72157632180303367/), Corriere della Sera. (Nov 25, 2012)](nobels.jpg){width="100%"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set it as external as e.g. David does here.
theme( | ||
plot.background = element_rect(fill = "#f2ebde", color = NA)) | ||
|
||
final_plot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Super neat!
theme( | ||
plot.background = element_rect(fill = "#f2ebde", color = NA)) | ||
|
||
final_plot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is that fonts in general are a little small in this last graph. The legend is hard to read even at full page.
BTW, you don't need to merge the main repo into your fork. Don't waste the time with that. I'll resolve the conflicts when this is ready, don't worry. |
I have written an initial version of the post. Check it out and tell me if changes are needed.