Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project - Gür Piren #97

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Project - Gür Piren #97

wants to merge 3 commits into from

Conversation

gpiren
Copy link

@gpiren gpiren commented Jan 7, 2025

This study displays the evolution of BMI values of Olympic athletes who competed in the Summer Olympic Games of 1960 and 2016.

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for mucss-dataviz ready!

Name Link
🔨 Latest commit 9faf125
🔍 Latest deploy log https://app.netlify.com/sites/mucss-dataviz/deploys/677d5f5d3973bd00089877c1
😎 Deploy Preview https://deploy-preview-97--mucss-dataviz.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gpiren gpiren marked this pull request as ready for review January 7, 2025 14:03
gpiren added 2 commits January 7, 2025 15:06
…ots.

Added 'echo=TRUE' to each chunk.

Changed '#'s into '##' due to recommendation.
- Put a preview command to the replication graph
- Splitted some chunks into even smaller ones
- Added and changed explanations for the new and old chunks
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great job! Some minor comments below.

```{r setup, include=FALSE}
knitr::opts_chunk$set(out.width="100%", fig.align="center")
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a bit of introduction where you show us the selected graph (include a png in the PR and highlight it as e.g. David does here), and tell us why you chose it. Also, please link the original source.

---

```{r setup, include=FALSE}
knitr::opts_chunk$set(out.width="100%", fig.align="center")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are global options. So if you add echo=TRUE to this function call, you can remove it from every other chunk. ;-)


```{r, echo=TRUE}

data_main <- read_csv("/Users/gpen/Dropbox/Mac/Desktop/Version Control/dataviz_gur_piren/athlete_events.csv")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include this CSV in this PR close to this Rmd. Then, you can read the file just with the name, removing any path from your computer.


```{r}

#| eval: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, this is the default.

Let's first read the data and start with the improvement.

```{r, echo=TRUE}
athletes <- read.csv("/Users/gpen/Dropbox/Mac/Desktop/Version Control/dataviz_gur_piren/athlete_events.csv")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, remove the path when you include the file in the PR.

Comment on lines +796 to +797
men_sports <- c("Athletics", "Canoeing", "Swimming", "Shooting", "Weightlifting", "Gymnastics", "Basketball", "Boxing", "Sailing", "Hockey", "Wrestling")
women_sports <- c("Gymnastics", "Athletics", "Fencing", "Canoeing", "Swimming", "Diving", "Sailing")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap these two lines a little adding newlines, because they go off the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants