Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project – Isabel Monge #90

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Project – Isabel Monge #90

merged 5 commits into from
Jan 16, 2025

Conversation

isabelmonge
Copy link
Contributor

This is my first draft! My main issues are embedding the Shiny app directly and fixing long code (titles, captions) that runs off the page. I tried one wrapping solution without success, and another using fvextra, but it's not available for my R version. I’d appreciate any advice on these issues and welcome any other feedback you may have.

https://stackoverflow.com/questions/26210656/in-r-markdown-in-rstudio-how-can-i-prevent-the-source-code-from-running-off-a-p

…rectly and fixing long code (titles, captions) that runs off the page. I tried one wrapping solution without success, and another using fvextra, but it's not available for my R version. I’d appreciate any advice on these issues and welcome any other feedback you may have.

https://stackoverflow.com/questions/26210656/in-r-markdown-in-rstudio-how-can-i-prevent-the-source-code-from-running-off-a-p
Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for mucss-dataviz ready!

Name Link
🔨 Latest commit 57988a1
🔍 Latest deploy log https://app.netlify.com/sites/mucss-dataviz/deploys/6788ef15f6b04c00084bd26a
😎 Deploy Preview https://deploy-preview-90--mucss-dataviz.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Enchufa2 Enchufa2 marked this pull request as ready for review January 9, 2025 20:33
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some minor comments below.

_projects/2024/100542532/100542532.Rmd Outdated Show resolved Hide resolved
_projects/2024/100542532/100542532.Rmd Outdated Show resolved Hide resolved
_projects/2024/100542532/100542532.Rmd Outdated Show resolved Hide resolved
_projects/2024/100542532/100542532.Rmd Outdated Show resolved Hide resolved
@Enchufa2
Copy link
Member

Enchufa2 commented Jan 9, 2025

About your issues:

This is my first draft! My main issues are embedding the Shiny app directly

As discussed with other classmates during the presentations, this is not possible. The only possibility would be to publish e.g. a dashboard in shinyapps.io, then link it here. But I'm mainly interested in the static part, don't waste so much time in that.

and fixing long code (titles, captions) that runs off the page. I tried one wrapping solution without success, and another using fvextra, but it's not available for my R version. I’d appreciate any advice on these issues and welcome any other feedback you may have.

The only solution for text that runs off the page is to break it in chunks and paste them together. For example, instead of

text <- "suppose that this is a very large piece of text"

you can do

text <- paste(c(
  "suppose",
  "that this",
  "is a very",
  "large piece",
  "of text"
  ), collapse=" ")

etc.

@Enchufa2
Copy link
Member

Just a kind reminder that the deadline is tomorrow. :)

-- Added a caption under the photo.
-- Removed title bolding.
-- Removed the .Rdata file and kept only the correctly formatted CSV.
-- Experimented with using paste for the caption, but it wasn't formatting correctly, so I left it as is for the sake of ensuring the graph displays well.
-- Enabled preview = TRUE for the final plot.
-- Added a caption under the photo.
-- Removed title bolding.
-- Removed the .Rdata file and kept only the correctly formatted CSV.
-- Experimented with using paste for the caption, but it wasn't formatting correctly, so I left it as is for the sake of ensuring the graph displays well.
-- Enabled preview = TRUE for the final plot.
@isabelmonge
Copy link
Contributor Author

The first pull request didn’t work as expected, but the second one should be correct. Please let me know, thank you!

@isabelmonge isabelmonge requested a review from Enchufa2 January 15, 2025 18:22
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merging after some adjustments and cleanup!

@Enchufa2 Enchufa2 merged commit 3bc6ad6 into IBiDat:main Jan 16, 2025
4 checks passed
@Enchufa2
Copy link
Member

Here you are, congrats! https://csslab.uc3m.es/dataviz/projects/2024/100542532/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants