-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project - Mencía Gómez #84
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mucss-dataviz ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Some minor comments below.
title: "Global Map of Migration" | ||
description: | | ||
Recreation and improvement of an EOM plot | ||
author: Mencía Gómez Luna |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mencía Gómez-Luna, or the template will recongnize "Luna" as your surname.
description: | | ||
Recreation and improvement of an EOM plot | ||
author: Mencía Gómez Luna | ||
date: 2024-12-21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be date: "`r Sys.Date()`"
toc: true | ||
--- | ||
|
||
# WHY DID I CHOOSE THIS PLOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All titles in sentence case, please.
- Use
##
for sections instead, and###
and so on for subsections, please.
|
||
This document contains the following parts: | ||
|
||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the >
line before each element of the list, please.
--- | ||
|
||
# WHY DID I CHOOSE THIS PLOT | ||
I wanted to replicate and improve the EOM plot (https://elordenmundial.com/mapas-y-graficos/inmigrantes-en-el-mundo/) for several reasons. First of all, I chose it since I had never recreated a map before (unlike other types of plots that I already knew how to make such as barplots, boxplots, histograms, etc.). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the original plot, with a caption and as "external" as e.g. David does here.
datos <- read.xlsx("migraciones_final.xlsx", sheet = 1) | ||
|
||
# BASE MAP | ||
mapa_mundial <- st_as_sf(getMap(resolution = "low")) #The resolution is low because we don't need very millimetrically details as in other types of more specific maps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this comment in its own line so that it doesn't go out of view.
We join map + barplot + source + images + title: | ||
|
||
```{r} | ||
#| fig.asp: 0.7 # to adjust how the plot appears |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add preview: true
as a chunk option too so that this image is shown in the project list.
plot <- plot_grid( | ||
ggdraw() + | ||
draw_text("Global Map of Migration", size = 26, x = 0.08, y = 0.3, hjust = 0, fontface = "bold") + | ||
draw_text("% of immigrants and flows of migration (2017)", size = 18, x = 0.08, y = 0.01, hjust = 0, fontface = "bold", color = "#444444"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line goes out of view, insert a new line somewhere in the middle to avoid this.
# IÑAKI'S ADVICE | ||
|
||
Here I tried to apply Iñaki's advice to improve the plot, specifically I take into account these suggestion: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to mention me all the time: :D
|
||
# QUESTIONS | ||
|
||
First, I think it's better -as you said- that the blue and dark colors are related to lower values and the higher values are represented with more lighter and yellowish colors. But what do you think about the logarithmic scale? I think that thanks to it we can highlight better the differences between countries than with the continuous scale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please try to avoid things like "as you said", because this post is not for me, it's also for you, it's for everyone! So imagine some random person arrives to your project and reads this... :)
First version of the project (plot on migrations).
Added: Check that the year folder has been created correctly (2024) and inside there's the folder with my NIA (100431421)