Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project - Jason Brunner #80

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Project - Jason Brunner #80

merged 6 commits into from
Jan 13, 2025

Conversation

Jbrunner1809
Copy link
Contributor

My first draft.

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for mucss-dataviz ready!

Name Link
🔨 Latest commit 2da5f23
🔍 Latest deploy log https://app.netlify.com/sites/mucss-dataviz/deploys/67852edb9aa59f0008bdd1bb
😎 Deploy Preview https://deploy-preview-80--mucss-dataviz.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Will double check for spelling errors in the next days. Open for any feedback
@Jbrunner1809 Jbrunner1809 marked this pull request as ready for review January 3, 2025 17:14
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some comments below.

_projects/2024/100543010/100543010.Rmd Outdated Show resolved Hide resolved
_projects/2024/100543010/100543010.Rmd Outdated Show resolved Hide resolved
_projects/2024/100543010/100543010.Rmd Outdated Show resolved Hide resolved
_projects/2024/100543010/100543010.Rmd Show resolved Hide resolved
_projects/2024/100543010/100543010.Rmd Outdated Show resolved Hide resolved
…would be nicer to not need to just copy past the ones for the labels down, but when I try to put them in to a variable i get an error. First i thought its caused by the geom_point parts but also just the ones with annotate dont work. I also tried bypassing it by formating them as a list, but this did not work aswell :/. I hope its still allright like this.
@Jbrunner1809 Jbrunner1809 marked this pull request as draft January 12, 2025 19:13
@Enchufa2 Enchufa2 marked this pull request as ready for review January 13, 2025 15:12
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging!

@Enchufa2 Enchufa2 merged commit 6ccd351 into IBiDat:main Jan 13, 2025
3 of 4 checks passed
@Enchufa2
Copy link
Member

Congrats, here you are: https://csslab.uc3m.es/dataviz/projects/2024/100543010/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants