Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project - Irene Bosque Gala #78

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Project - Irene Bosque Gala #78

merged 7 commits into from
Jan 15, 2025

Conversation

irenebosque25
Copy link
Contributor

Creating a new pull request

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for mucss-dataviz ready!

Name Link
🔨 Latest commit 9c8794d
🔍 Latest deploy log https://app.netlify.com/sites/mucss-dataviz/deploys/6788049ef4319b000864f2e4
😎 Deploy Preview https://deploy-preview-78--mucss-dataviz.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@irenebosque25
Copy link
Contributor Author

.

@irenebosque25 irenebosque25 marked this pull request as ready for review December 26, 2024 18:18
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some comments below.

_projects/2024/100535296/100535296.Rmd Outdated Show resolved Hide resolved
_projects/2024/100535296/100535296.Rmd Outdated Show resolved Hide resolved
_projects/2024/100535296/100535296.Rmd Outdated Show resolved Hide resolved
_projects/2024/100535296/100535296.Rmd Show resolved Hide resolved
_projects/2024/100535296/100535296.Rmd Outdated Show resolved Hide resolved
_projects/2024/100535296/100535296.Rmd Outdated Show resolved Hide resolved
@Enchufa2
Copy link
Member

Just a kind reminder that the deadline is tomorrow. :)

@Enchufa2
Copy link
Member

Are you still working on this? Some (most) comments were not addressed.

@irenebosque25
Copy link
Contributor Author

Hello! I'm so sorry, I think I uploaded the wrong file. I think now should be good. Thank you very much!

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice work! I tried to tweak figure sizes a bit, but not having used fig.showtext=TRUE from the beginning turned problematic, and we don't have more time for fine tuning. Merging!

@Enchufa2 Enchufa2 merged commit d0160fd into IBiDat:main Jan 15, 2025
4 checks passed
@Enchufa2
Copy link
Member

And here you are, congrats! https://csslab.uc3m.es/dataviz/projects/2024/100535296/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants