-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project - Brad McKenzie #75
Conversation
✅ Deploy Preview for mucss-dataviz ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Iñaki, the initial version of my project is ready for review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Some comments below.
Also, please add |
Just a kind reminder that the deadline is tomorrow. :) |
Hello! All comments should now be addressed. I have committed changes and pushed back for any final checks and changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Merging after adding the resulting images too.
Here's your post, congrats! https://csslab.uc3m.es/dataviz/projects/2024/100535241/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found an error on the publication with the image final plot image generation, may need to push/pull my own figure-html5 folder?
_projects/2024/100535241/100535241_files/figure-html5/final-legend-joinplot-1.png
Show resolved
Hide resolved
Ah, let me see if I can fix it. |
Better now? The limits of the inset were... odd. I've also removed the need for saving the legend in the first place. |
Thanks for the removal of the image save, more efficient. Your changes look sensible, but it has cut off the last few letters of the legend and changed the sizing a bit. I'm not too worried about the exactness of it. But just to ensure it's all at least readable, can you update these lines of code? I don't think I can do it now that it's published to your main repos. Line 458: (to expand legend width to show the full labels) Lines 489-493: (slight realignment/sizing) Apologies for the minor adjustments. Hopefully my checks line up and this finalises it!!! |
Ok, done! |
Thank you! Fixed :) |
Initial request to setup dataviz final project