-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project - Jia Lin #71
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mucss-dataviz ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Updated content for the final project(first version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Some comments:
- Please move the files under the
_projects/2024/100536210
directory, i.e. the one starting with the underscore. You should leaveprojects
unchanged. - Please add a caption to the original plot at the beginning, and set it as "external" as e.g. David does here.
- When you use
read_delim
, use just"goal12.cwon.csv"
, not the whole path in your computer. It's not necessary because the file is next to the Rmd. - There are chunks that would produce a plotly output, but you instead include an image. It would be better to actually execute those chunks and let the document render the plotly result, instead of adding the image manually.
It's a pitty that you don't use ggplot2 at all. It's nice to provide an interactive version, but the course is about ggplot2.
Dear Iñaki,
Happy new year!
Thank you very much for your detailed feedback and constructive suggestions
on my project. I have carefully reviewed each point and would like to
address them as follows:
1.
*File Structure*:
I will move the files under the _projects/2024/100536210 directory as
suggested, leaving the projects folder unchanged.
2.
*Plot Caption*:
I will add a caption to the original plot at the beginning of the
document and set it as "external," as recommended.
3.
*File Path in read_delim*:
I will modify the code to use "goal12.cwon.csv" directly instead of the
full path. This adjustment will make the code cleaner and ensure better
portability.
4.
*Plotly Output and Image*:
Regarding the chunks that produce a Plotly output, the reason I included
images instead of directly rendering the plots is due to the use of Shiny
in this part of the code. Without adding images manually, it was not
possible to render the plots properly in the R Markdown document. If you
have suggestions or alternatives to improve this implementation, I would be
more than happy to explore them and adapt the project accordingly.
5.
*Use of ggplot2*:
I understand your concern about the focus of the course on ggplot2. My
decision to use Plotly was driven by its efficiency and simplicity for
creating interactive and dynamic visualizations. I found its logic to be
somewhat similar to ggplot2, and my ability to implement it was based on
the concepts I learned in this course.
That being said, I understand that aligning with the course objectives
is important. I would like to ask whether not using ggplot2 in this
specific case might affect the evaluation of my project. If so, I will put
in the effort to revise the project and incorporate ggplot2
visualizations, even though my earlier attempts did not yield the ideal
results.
Thank you again for your guidance and feedback. I will make the necessary
adjustments promptly and update the pull request. Please let me know if
there are any additional points or suggestions I should consider.
Best regards,
Jia Lin
Iñaki Ucar ***@***.***> 于2024年12月26日周四 21:48写道:
… ***@***.**** requested changes on this pull request.
Nice work! Some comments:
- Please move the files under the _projects/2024/100536210 directory,
i.e. the one starting with the underscore. You should leave projects
unchanged.
- Please add a caption to the original plot at the beginning, and set
it as "external" as e.g. David does here
<https://github.com/IBiDat/dataviz/blob/81084e40371bd8161998806e9c7471e04ad47cfe/_projects/2024/100535712/100535712.Rmd#L26>
.
- When you use read_delim, use just "goal12.cwon.csv", not the whole
path in your computer. It's not necessary because the file is next to the
Rmd.
- There are chunks that would produce a plotly output, but you instead
include an image. It would be better to actually execute those chunks and
let the document render the plotly result, instead of adding the image
manually.
It's a pitty that you don't use ggplot2 at all. It's nice to provide an
interactive version, but the course is about ggplot2.
—
Reply to this email directly, view it on GitHub
<#71 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BD3HW2HYT4ADASCSG6LLQH32HRTSNAVCNFSM6AAAAABRJIHNOWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRTGQ3TSNBQGQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Yes, it would be great if you could add a replication in ggplot2 at the beginning, and then switch to plotly as an improvement. |
First version of the individual project