Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project - Jia Lin #71

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Project - Jia Lin #71

wants to merge 9 commits into from

Conversation

JacklynLin
Copy link

@JacklynLin JacklynLin commented Nov 6, 2024

First version of the individual project

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for mucss-dataviz ready!

Name Link
🔨 Latest commit 042e9eb
🔍 Latest deploy log https://app.netlify.com/sites/mucss-dataviz/deploys/6782d0f0722f2a0008ab083e
😎 Deploy Preview https://deploy-preview-71--mucss-dataviz.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JacklynLin JacklynLin closed this Nov 6, 2024
@JacklynLin JacklynLin reopened this Nov 6, 2024
@JacklynLin JacklynLin closed this Nov 8, 2024
@JacklynLin JacklynLin reopened this Nov 8, 2024
@JacklynLin JacklynLin changed the title Project - <Jia Lin> Project - <Jia Lin>/Work In Progress Nov 8, 2024
@Enchufa2 Enchufa2 marked this pull request as draft November 8, 2024 11:40
@Enchufa2 Enchufa2 changed the title Project - <Jia Lin>/Work In Progress Project - Jia Lin Nov 8, 2024
@JacklynLin JacklynLin marked this pull request as ready for review December 23, 2024 21:59
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Some comments:

  • Please move the files under the _projects/2024/100536210 directory, i.e. the one starting with the underscore. You should leave projects unchanged.
  • Please add a caption to the original plot at the beginning, and set it as "external" as e.g. David does here.
  • When you use read_delim, use just "goal12.cwon.csv", not the whole path in your computer. It's not necessary because the file is next to the Rmd.
  • There are chunks that would produce a plotly output, but you instead include an image. It would be better to actually execute those chunks and let the document render the plotly result, instead of adding the image manually.

It's a pitty that you don't use ggplot2 at all. It's nice to provide an interactive version, but the course is about ggplot2.

@JacklynLin
Copy link
Author

JacklynLin commented Jan 4, 2025 via email

@Enchufa2
Copy link
Member

Plotly Output and Image: Regarding the chunks that produce a Plotly output, the reason I included images instead of directly rendering the plots is due to the use of Shiny in this part of the code. Without adding images manually, it was not possible to render the plots properly in the R Markdown document. If you have suggestions or alternatives to improve this implementation, I would be more than happy to explore them and adapt the project accordingly.

  • In the chunks where you want to show a table, you could just call e.g. head(goal_12) at the end of the chunk to automatically show a few rows of that specific dataframe, instead of including an image.
  • In the plotly chunks, ok, I see the issue. You can leave the images.
  1. Use of ggplot2: I understand your concern about the focus of the course on ggplot2. My decision to use Plotly was driven by its efficiency and simplicity for creating interactive and dynamic visualizations. I found its logic to be somewhat similar to ggplot2, and my ability to implement it was based on the concepts I learned in this course. That being said, I understand that aligning with the course objectives is important. I would like to ask whether not using ggplot2 in this specific case might affect the evaluation of my project. If so, I will put in the effort to revise the project and incorporate ggplot2 visualizations, even though my earlier attempts did not yield the ideal results.

Yes, it would be great if you could add a replication in ggplot2 at the beginning, and then switch to plotly as an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants