Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project - Linghan Zheng #67

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Project - Linghan Zheng #67

merged 10 commits into from
Jan 13, 2025

Conversation

Leeann954
Copy link
Contributor

It's my first draft on Github.

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for mucss-dataviz ready!

Name Link
🔨 Latest commit d4cbbfa
🔍 Latest deploy log https://app.netlify.com/sites/mucss-dataviz/deploys/678529aeae7df500089e7f3f
😎 Deploy Preview https://deploy-preview-67--mucss-dataviz.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Leeann954 Leeann954 marked this pull request as ready for review December 22, 2024 23:46
@Leeann954 Leeann954 changed the title Project - <Linghan Zheng> Project - Linghan Zheng Dec 24, 2024
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great work. But the idea is that the file called _projects/2024/100540803/100540803.Rmd should be your post, so that it's integrated in the webpage's projects section. So could you please move the contents of first version.qmd to the file above and remove this qmd as well as first-version_files and first version_files? If you need the images directory, that should be moved under _projects/2024/100540803 too.

@Leeann954
Copy link
Contributor Author

Hi Iñaki,

I have already moved the file to _projects/2024/100540803/100540803.Rmd and deleted the original first version. However, I'm now encountering this conflict message regarding projects.html, projects/projects.json, and sitemap.xml. Could you help me resolve this issue or guide me on the next steps to take?

Thanks!
image

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the work! Some minor comments below. And don't worry about the conflicts, I'll deal with that.

_projects/2024/100540803/100540803.Rmd Outdated Show resolved Hide resolved
_projects/2024/100540803/100540803.Rmd Outdated Show resolved Hide resolved
_projects/2024/100540803/100540803.Rmd Outdated Show resolved Hide resolved
_projects/2024/100540803/100540803.Rmd Outdated Show resolved Hide resolved
_projects/2024/100540803/100540803.Rmd Outdated Show resolved Hide resolved
@Leeann954
Copy link
Contributor Author

Hi Iñaki,
I’ve implemented all the requested changes and addressed the feedback. Please review the updates and let me know if there’s anything else that needs further adjustment. Thank you!

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merging!

@Enchufa2 Enchufa2 merged commit d1956e5 into IBiDat:main Jan 13, 2025
4 checks passed
@Enchufa2
Copy link
Member

Congrats, here you are: https://csslab.uc3m.es/dataviz/projects/2024/100540803/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants