plugin scheduler #3
Closed
+2,138
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yannick Schnider <[email protected]>
Signed-off-by: Yannick Schnider <[email protected]>
Closed
sducouedic
requested changes
Feb 6, 2025
| # VLLM_SPYRE_WARMUP_PROMPT_LENS: Optional[List[int]] = None | ||
| # VLLM_SPYRE_WARMUP_NEW_TOKENS: Optional[List[int]] = None | ||
| # VLLM_SPYRE_WARMUP_BATCH_SIZES: Optional[List[int]] = None | ||
| VLLM_SPYRE_WARMUP_PROMPT_LENS: Optional[List[int]] = None |
There was a problem hiding this comment.
need to add Optional and List in the import
There was a problem hiding this comment.
good catch! they went missing when I resolved conflicts in the web editor. I had them locally.
added again here: commit
Signed-off-by: Yannick Schnider <[email protected]>
|
this PR is replaced by an alternative implementation see this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding spyre specific scheduler
This PR integrates the (spyre specific) scheduler class to replace the upstream scheduler.
it goes along with this ->PR<- in the
vllmrepositoryChanges:
vllm_spyre/config.py: file containing the spyre specificSchedulerConfigclassvllm_spyre/core/scheduler.py: file containing the spyre specificSchedulerclassvllm_spyre/envs.py: adding spyre scheduler related env variables.