Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze/head/decoder #378

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Freeze/head/decoder #378

merged 4 commits into from
Jan 30, 2025

Conversation

Joao-L-S-Almeida
Copy link
Member

@Joao-L-S-Almeida Joao-L-S-Almeida commented Jan 21, 2025 •
edited
Loading

Freezing decoder and head separately for EOFMs.

@Joao-L-S-Almeida
EO models could freeze decoder and head separately
eb20bf8 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Argument to inform if the head will be frozen or not
1fdb5f5 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
4.35.0
8493e34 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@romeokienzler
Copy link
Collaborator

@Joao-L-S-Almeida I get 22 test errors using requirements/require.txt

========================================================================================================== short test summary info ===========================================================================================================
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[fit-prithvi_swin_B] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[fit-prithvi_swin_L] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[fit-prithvi_vit_100] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[fit-prithvi_eo_v2_300] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[fit-prithvi_eo_v2_600] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[test-prithvi_swin_B] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[test-prithvi_swin_L] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[test-prithvi_vit_100] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[test-prithvi_eo_v2_300] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[test-prithvi_eo_v2_600] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[validate-prithvi_swin_B] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[validate-prithvi_swin_L] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[validate-prithvi_vit_100] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[validate-prithvi_eo_v2_300] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[validate-prithvi_eo_v2_600] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_bands_intervals[fit-prithvi_swin_B] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_bands_intervals[test-prithvi_swin_B] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_bands_intervals[validate-prithvi_swin_B] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_bands_str[fit-prithvi_swin_B] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_bands_str[test-prithvi_swin_B] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_bands_str[validate-prithvi_swin_B] - SystemExit: 2
FAILED tests/test_finetune.py::test_finetune_metrics_from_file[prithvi_swin_B] - SystemExit: 2

@Joao-L-S-Almeida
Merge with main
b5c0c0e 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
@Joao-L-S-Almeida
Copy link
Member Author

It reminds me the issue with jsonargparse, @romeokienzler
Maybe you need to force jsonargparse <= 4.35.0.

@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Jan 28, 2025
@Joao-L-S-Almeida Joao-L-S-Almeida merged commit 89b913d into main Jan 30, 2025
7 checks passed
@Joao-L-S-Almeida Joao-L-S-Almeida deleted the freeze/head/decoder branch January 30, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romeokienzler romeokienzler romeokienzler approved these changes

@blumenstiel blumenstiel Awaiting requested review from blumenstiel

@paolofraccaro paolofraccaro Awaiting requested review from paolofraccaro

Assignees

@Joao-L-S-Almeida Joao-L-S-Almeida

Labels
0.99.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joao-L-S-Almeida @romeokienzler