Add deprecation warning for scale_modules
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesc Marti Escofet <[email protected]>
Signed-off-by: Francesc Marti Escofet <[email protected]>
|
Yes, that is a valid warning. Maybe we need to remove it before 1.0. |
Joao-L-S-Almeida
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @blumenstiel in #352 I would suggest to deprecate
scale_modulesfrom theUperNetDecoder. This parameter was implemented before there were necks and therefore it was necessary to scale the features inside the decoder. With the introduction of necks this can be done with theLearnedInterpolateToPyramidalneck and I believe it's better to use a neck as it should not be part of the decoder.I would suggest to fully remove it before releasing v1 but we give some warning before in case people use it.