Feat: Implement option to have multiple learning rates #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesc Marti Escofet <[email protected]>
fmartiescofet
force-pushed
the
reduce_lr
branch
from
960da6c to
bc119a4
Compare
fmartiescofet
changed the title
fmartiescofet
force-pushed
the
reduce_lr
branch
from
bc119a4 to
468bca3
Compare
Signed-off-by: Francesc Marti Escofet <[email protected]>
fmartiescofet
force-pushed
the
reduce_lr
branch
from
468bca3 to
2fb9383
Compare
fmartiescofet
changed the title
fmartiescofet
changed the title
Signed-off-by: Francesc Marti Escofet <[email protected]>
fmartiescofet
changed the title
Signed-off-by: Francesc Marti Escofet <[email protected]>
Signed-off-by: Francesc Marti Escofet <[email protected]>
Joao-L-S-Almeida
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the option
lr_overridesin all the tasks which allow the user to use custom learning rates for different parameters (e.g. it may want to have a lower lr in the encoder vs the decoder).CC: @blumenstiel @paolofraccaro