Handle empty response for registration call

Signed-off-by: Rob Hundley <[email protected]>
IBM · Jan 29, 2025 · 7eecd99 · 7eecd99
1 parent 942872a
commit 7eecd99
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/controllers/oidc.security/errors.go b/controllers/oidc.security/errors.go
@@ -56,6 +56,7 @@ func NewOIDCClientRegistrationError(clientID, requestMethod, origErrMsg string,
 		return
 	}
 	if response == nil || response.Body == nil {
+		oidcErr.Description = "no response received"
 		return
 	}
 	defer response.Body.Close()

diff --git a/controllers/oidc.security/zen_registration.go b/controllers/oidc.security/zen_registration.go
@@ -56,7 +56,7 @@ func (r *ClientReconciler) getZenInstanceRegistration(ctx context.Context, clien
 	switch v := err.(type) {
 	case *OIDCClientRegistrationError:
 		// Return no response or error if the OIDC client isn't found given a token couldn't be retrieved
-		if v.response.StatusCode == 404 {
+		if v.response != nil && v.response.StatusCode == 404 {
 			return nil, nil
 		}
 		return
-Original file line number
+Diff line change
@@ Expand Up @@
     		return
     	}
     	if response == nil || response.Body == nil {
+    		oidcErr.Description = "no response received"
     		return
     	}
     	defer response.Body.Close()
@@ Expand Down @@