This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Math subtract 19 #47
Closed
Math subtract 19 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neumannrf
suggested changes
Mar 21, 2019
main.py
Outdated
| port = os.getenv('PORT', '5000') | ||
| if __name__ == "__main__": | ||
| app.run(host='0.0.0.0', port=int(port)) | ||
| app.run(host='0.0.0.0', port=int(port)) |
There was a problem hiding this comment.
Para evitar que o flake8 acuse um erro, por favor, adicione uma nova linha em branco no final de main.py.
src/math_services.py
Outdated
| subtracted_list = [x - integer_value for x in integer_list] | ||
| integer_list.clear() | ||
| integer_list.extend(subtracted_list) | ||
| return integer_list |
There was a problem hiding this comment.
Para evitar que o flake8 acuse um erro, por favor, adicione uma nova linha em branco no final de src/math_services.py.
test/math_test.py
Outdated
| assert ms.subtract_list([1], 0) == [1] | ||
| assert ms.subtract_list([1], 1) == [0] | ||
| assert ms.subtract_list([1, 2], 1) == [0, 1] | ||
| assert ms.subtract_list([1, 2, 3], 1) == [0, 1, 2] |
There was a problem hiding this comment.
Para evitar que o flake8 acuse um erro, por favor, adicione uma nova linha em branco no final de test/math_test.py.
neumannrf
suggested changes
Mar 22, 2019
There was a problem hiding this comment.
@Albertomendonca Após as resoluções dos conflitos apontados pelo GitHub este PR poderá ser aprovado.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
requirements.txt.external.external.Related Issue
Closes #19
Notes to Reviewer
...