Update ECDSASignature to match expected behaviour #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method engineSetParameter that gets an AlgorithmParameterSpec as a parameter is implemented, thus overriding the existing version that just throws an UnsupportedOperationException. The engineSetParameter that gets String and Object parameters is updated to match the behaviour of similar implementations from other providers. Override annotations are added to specific methods to enforce checks. A few more test cases are added to check the new functionality. Signed-off-by: Kostas Tsiounis <[email protected]>
KostasTsiounis
requested review from
taoliult,
jasonkatonica,
johnpeck-us-ibm and
JinhangZhang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
engineSetParameterthat gets anAlgorithmParameterSpecas a parameter is implemented, thus overriding the existing version that just throws anUnsupportedOperationException.The
engineSetParameterthat getsStringandObjectparameters is updated to match the behaviour of similar implementations from other providers.Overrideannotations are added to specific methods to enforce checks.A few more test cases are added to check the new functionality.
Back-ported from: #416
Signed-off-by: Kostas Tsiounis [email protected]