Eliminate older junit dependency #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The older junit dependency is still configured in the pom.xml mvn file as a dependency. This update removes this dependency and migrates all codes to junit jupiter framework. In particular the following changes were made. 1. The `pom.xml` file was updated to remove the junit dependency. It was replaced by just the hamcrest portion of the features that are used in the project. 1. All imports are now being done from the `org.junit.jupiter.api` package instead of `org.junit`. 1. Various assertions required the message string to be last argument to the method instead of first. Signed-off-by: Jason Katonica <[email protected]>
jasonkatonica
requested review from
taoliult,
KostasTsiounis,
johnpeck-us-ibm and
JinhangZhang
johnpeck-us-ibm
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older junit dependency is still configured in the pom.xml mvn file as a dependency. This update removes this dependency and migrates all codes to junit jupiter framework. In particular the following changes were made.
The
pom.xmlfile was updated to remove the junit dependency. It was replaced by just the hamcrest portion of the features that are used in the project.All imports are now being done from the
org.junit.jupiter.apipackage instead oforg.junit.Various assertions required the message string to be last argument to the method instead of first.
Back-ported from: #410
Signed-off-by: Jason Katonica [email protected]