change affiliation field from mandatory to optional #3
Conversation
| @@ -171,7 +171,9 @@ String getName() { | |||
| } | |||
|
|
|||
| String getMspid() { | |||
There was a problem hiding this comment.
I would be careful here and in other places as I don't think these are optional. If they're not present probably should throw some type of exeception.
There was a problem hiding this comment.
If the field is required, should I remove the checking?
There was a problem hiding this comment.
That's one option. I would think better throwing an exception with an error that the field was missing from the NetworkConfig document.
There was a problem hiding this comment.
Have you done some testing with this change ?
There was a problem hiding this comment.
I only do the testing with "affiliation" change from the Jason file. I will leave those fields untouched then
| @@ -292,15 +299,21 @@ public String getEventURL() { | |||
| } | |||
|
|
|||
| public String getEnrollId() { | |||
There was a problem hiding this comment.
Again I think there would always be an id here
| return value.getString("enrollId"); | ||
| if(value.containsKey("enrollId")) | ||
| return value.getString("enrollId"); | ||
| return null; | ||
| } | ||
|
|
||
| public String getAffiliation() { |
README.md
Outdated
|
|
||
| ## Hyperledger Fabric Java SDK Version | ||
| This code is dependent on a 1.1.0-SNAPSHOT | ||
| Requires Java SDK 1.1.0-SNAPSHOT |
There was a problem hiding this comment.
Probably should be Hyperledger Fabric Java SDK 1.1.0-SNAPSHOT
#2