Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement to scroll-to-top component #4338

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Improvement to scroll-to-top component #4338

merged 1 commit into from
Jan 13, 2025

Conversation

theskumar
Copy link
Member

@theskumar theskumar commented Jan 13, 2025 •
edited
Loading

  • Use passive=true in event listener for better performance without the need of throttle
  • More readible code
  • Make use of more modern scollY instead of pageYoffset
  • Improved docs
  • Add missing translation
  • No style change

@theskumar theskumar self-assigned this Jan 13, 2025
@theskumar
Improvement to scroll-to-top component
f5e5dee 
- More docs
- use passive=true in event listener for better performance without the
need of throttle
- more readible code
- make use of more modern scollY instead of pageYoffset
@theskumar theskumar force-pushed the enhancement/scroll-to-top branch from 76ad68b to f5e5dee Compare January 13, 2025 09:38
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Jan 13, 2025
@frjo frjo merged commit 014c337 into main Jan 13, 2025
7 checks passed
sandeepsajan0 pushed a commit that referenced this pull request Jan 26, 2025
@theskumar @sandeepsajan0
Improvement to scroll-to-top component (#4338)
133a893 
- Use passive=true in event listener for better performance without the
need of throttle
- More readible code
- Make use of more modern scollY instead of pageYoffset
- Improved docs
- Add missing translation
- No style change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frjo frjo frjo approved these changes

@wes-otf wes-otf Awaiting requested review from wes-otf

@sandeepsajan0 sandeepsajan0 Awaiting requested review from sandeepsajan0

Assignees

@theskumar theskumar

Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theskumar @frjo