Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker development environment update #4325

Merged
merged 11 commits into from
Jan 10, 2025
Merged

Conversation

frjo
Copy link
Member

@frjo frjo commented Jan 8, 2025

No description provided.

@frjo frjo changed the title Docker dev update Docker development environment update Jan 8, 2025
@frjo frjo added Type: Maintenance Type: Patch Mini change, used in release drafter Type: Documentation labels Jan 8, 2025
Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a huge improvement from the older version. Thanks for working on it.

I works great in my initial test, and will try use this setup more often, going forward we can look to dockerize the mkdocs as well.

I've left minor cosmetic suggestions.

docs/setup/deployment/development/docker.md Outdated Show resolved Hide resolved
docs/setup/deployment/production/docker.md Outdated Show resolved Hide resolved
docs/setup/deployment/development/docker.md Outdated Show resolved Hide resolved
@theskumar
Copy link
Member

In my experience, the --watch command doesn't sync the file properly. I changed a html file and it didn't update until I built the image again.

I don't much experience with it, saw it here first time.

@frjo
Copy link
Member Author

frjo commented Jan 9, 2025

@theskumar I have attempted to mount the hypha sub dir and sync everything else. Seems to work. Please try it out when you have time.

@frjo frjo merged commit 2c26a3c into main Jan 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants