Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project section header button's layout #4324

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

theskumar
Copy link
Member

  1. Fix project section header button's layout
  2. Update and fix the layout of supporting document display
    • add a bg to easily separate two document category
    • handle long filenames
    • add hover state to links / buttons

Fixes #4321

Screenshot 2025-01-08 at 3  49 20@2x

Screenshot 2025-01-08 at 9  27 29@2x

Test Steps

  • Checkout the project header and supporting documents.

- add a bg to easily separate two document category
- handle long filenames
- add hover state to links / buttons
@theskumar theskumar requested review from frjo and wes-otf January 8, 2025 09:31
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Status: Needs testing Tickets that need testing/qa Type: Patch Mini change, used in release drafter Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jan 8, 2025
@frjo
Copy link
Member

frjo commented Jan 8, 2025

Added my one line fix in #4322 to this PR instead.

@wes-otf
Copy link
Contributor

wes-otf commented Jan 9, 2025

hey @frjo is this deployed? seems fixed on the test instance but I don't see the new updates shown in the second pic

@frjo
Copy link
Member

frjo commented Jan 9, 2025

@wes-otf Seems to only show for "Contracting documents", not for "Project documents". Will see if I can fix that.

@frjo
Copy link
Member

frjo commented Jan 9, 2025

@wes-otf I have added the new style to Supporting documents as well now. Will be deployed to test in a few minuts.

@wes-otf
Copy link
Contributor

wes-otf commented Jan 9, 2025

looks slick, nice work y'all!

@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jan 9, 2025
@frjo frjo merged commit acaaced into main Jan 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project supporting document filenames buttons wrap weird
3 participants