Remove any limit on rows exported when the submission is exported #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frjo
approved these changes
Jan 8, 2025
frjo
added
Type: Enhancement
wes-otf
approved these changes
Jan 9, 2025
|
works well! definitely agree that moving forward we'll need some background worker to handle this (in the same way we need one for batch actions) - seems like the server even struggled a bit generating the 128 applications we have on the test instance |
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the export to use the filtered queryset without pagination. Unless we have proper way to generate a very large dataset. I believe it whould be better to let the server generate as much data it can possibily generate.
Fixes #4320
Test Steps