Fix report submit notification to stream field form flow #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frjo
added
Type: Bug
wes-otf
added
Status: Tested - changes/discussion needed 🔨
and removed
Status: Needs dev testing 🧑💻
|
hey @sandeepsajan0, I tried to submit a couple different reports here and here but it didn't seem like either sent any notifications, is there something I missed? |
|
My fault, forgot to push to test. Being deployed now. |
frjo
added
Status: Needs dev testing 🧑💻
|
Still doesn't seem to be working for me after the push, I tried submitting a report both as staff and as the applicant and on my end neither seemed to result in an email. The reports were overdue though so I'm not sure if that makes a difference? |
wes-otf
added
Status: Tested - changes/discussion needed 🔨
Status: Tested - approved for live ✅
and removed
Status: Needs dev testing 🧑💻
|
@frjo pointed out the notification came through slack - I had been looking for it via email for some reason. This should be good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4289
Test Steps