Skip to content

Commit

Permalink
Minor improvements to UI of submission beta (#3783)
Browse files Browse the repository at this point in the history
- Update the row spacing, make them more comfortable for reading with
increased padding top and bottom.
- Update the ordering on the dropdown items, essentially aligns the
"lead" and "reviewers" to be near the lead column and reviewers column
in the rows. They are expected to align, but in one of earlier feedback
people found it would be helpful if the "lead" dropdown was near the
"lead" column.
  • Loading branch information
theskumar authored Feb 27, 2024
1 parent 37b2f49 commit bec2899
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% load i18n querystrings %}
{% load heroicons %}

<div class="relative border-t md:flex flex-wrap md:flex-nowrap hover:bg-gray-100 w-full px-2">
<div class="relative border-t md:flex flex-wrap md:flex-nowrap hover:bg-gray-100 w-full px-2 py-1">

{% comment %} Select {% endcomment %}
<label class="hidden ps-1 py-2.5 sm:inline-flex">
Expand Down
42 changes: 21 additions & 21 deletions hypha/apply/funds/templates/submissions/all.html
Original file line number Diff line number Diff line change
Expand Up @@ -329,27 +329,7 @@
<p class="m-0 px-3 py-2 text-fg-muted" data-filter-empty-state hidden>{% trans "No statuses found. Sorry about that." %}</p>
{% enddropdown_menu %}

{% dropdown_menu title="Fund" heading="Filter by Fund &amp; Labs" enable_search=True %}
{% slot "url" %}{% url "apply:submissions:submenu-funds" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Round" heading="Filter by Round" enable_search=True %}
{% slot "url" %}{% url "apply:submissions:submenu-rounds" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Lead" heading="Filter by Lead" enable_search=True %}
{% slot "url" %}{% url "apply:submissions:submenu-leads" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Reviewers" heading="Filter by Reviewer" enable_search=True %}
{% slot "url" %}{% url "apply:submissions:submenu-reviewers" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Category" heading="Filter by Category" enable_search=True position="right" %}
{% slot "url" %}{% url "apply:submissions:submenu-category-options" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Screening" heading="Filter by screening decision" position="right" %}
{% dropdown_menu title="Screening" heading="Filter by screening decision" %}
<ul
class="flex flex-col overflow-scroll divide-y max-h-80 text-gray-700"
>
Expand All @@ -376,11 +356,31 @@
</ul>
{% enddropdown_menu %}

{% dropdown_menu title="Fund" heading="Filter by Fund &amp; Labs" enable_search=True %}
{% slot "url" %}{% url "apply:submissions:submenu-funds" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Round" heading="Filter by Round" enable_search=True %}
{% slot "url" %}{% url "apply:submissions:submenu-rounds" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Category" heading="Filter by Category" enable_search=True %}
{% slot "url" %}{% url "apply:submissions:submenu-category-options" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Terms" heading="Filter by Terms" enable_search=True position="right" %}
{% slot "url" %}{% url "apply:submissions:submenu-meta-terms" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Lead" heading="Filter by Lead" enable_search=True position="right" %}
{% slot "url" %}{% url "apply:submissions:submenu-leads" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}

{% dropdown_menu title="Reviewers" heading="Filter by Reviewer" enable_search=True position="right" %}
{% slot "url" %}{% url "apply:submissions:submenu-reviewers" %}{% remove_from_query "only_query_string" "page" %}{% endslot %}
{% enddropdown_menu %}


{% dropdown_menu title="Sort" heading="Sort by" position="right" %}
{% for sort_option in sort_options %}
<a
Expand Down

0 comments on commit bec2899

Please sign in to comment.