Remove stylelint rules that are no longer needed with later versions. (…

…#4303)
HyphaApp · Dec 31, 2024 · 556a848 · 556a848
1 parent de1e4fe
commit 556a848
Show file tree

Hide file tree

Showing 20 changed files with 13 additions and 100 deletions.
diff --git a/.stylelintrc.yaml b/.stylelintrc.yaml
@@ -1,73 +1,9 @@
 extends:
-  - stylelint-config-standard
   - stylelint-config-standard-scss
 rules:
-  at-rule-disallowed-list:
-    - debug
-  at-rule-no-unknown: null
-  at-rule-no-vendor-prefix: true
-  block-no-empty: null
-  color-hex-length: short
-  color-named: never
-  color-no-invalid-hex: true
   declaration-block-no-redundant-longhand-properties: null
-  declaration-block-single-line-max-declarations: 1
   declaration-empty-line-before: null
-  declaration-no-important: true
-  declaration-property-value-disallowed-list:
-    border:
-      - none
-    border-top:
-      - none
-    border-right:
-      - none
-    border-bottom:
-      - none
-    border-left:
-      - none
-  font-family-name-quotes: null
-  function-url-quotes: always
-  length-zero-no-unit: true
-  max-nesting-depth:
-    - 4
-    - ignoreAtRules:
-        - each
-        - media
-        - supports
-        - include
-  media-feature-name-no-vendor-prefix: true
-  media-feature-range-notation: prefix
   no-descending-specificity: null
-  property-no-unknown: true
-  property-no-vendor-prefix: true
-  rule-empty-line-before:
-    - always-multi-line
-    - except:
-        - first-nested
-      ignore:
-        - after-comment
-  scss/at-extend-no-missing-placeholder: true
-  scss/at-function-pattern: "^[a-z]+([a-z0-9-]+[a-z0-9]+)?$"
-  scss/load-no-partial-leading-underscore: true
-  scss/at-import-partial-extension-disallowed-list:
-    - scss
-  scss/at-mixin-pattern: "^[a-z]+([a-z0-9-]+[a-z0-9]+)?$"
-  scss/at-rule-no-unknown: true
-  scss/comment-no-empty: null
-  #scss/dollar-variable-colon-space-after: always
-  scss/dollar-variable-colon-space-before: never
-  scss/dollar-variable-pattern: "^[_]?[a-z]+([a-z0-9-]+[a-z0-9]+)?$"
-  scss/no-global-function-names: null
-  #scss/percent-placeholder-pattern: "^[a-z]+([a-z0-9-]+[a-z0-9]+)?$"
-  #scss/selector-no-redundant-nesting-selector: true
   selector-class-pattern:
     - "^[a-z0-9\\-]+$"
     - message: Selector should be written in lowercase with hyphens (selector-class-pattern)
-  selector-max-compound-selectors: 3
-  selector-max-id: 0
-  #selector-no-qualifying-type: true
-  selector-no-vendor-prefix: true
-  selector-pseudo-element-colon-notation: double
-  selector-pseudo-element-no-unknown: true
-  shorthand-property-no-redundant-values: true
-  value-no-vendor-prefix: true
diff --git a/hypha/static_src/sass/abstracts/_mixins.scss b/hypha/static_src/sass/abstracts/_mixins.scss
@@ -1,11 +1,10 @@
 @use "sass:list";
 @use "functions";
 @use "variables";
-
-// stylelint-disable
-
 @use "sass:math";
 
+// stylelint-disable scss/at-mixin-pattern
+
 // Media queries
 @mixin media-query($queries...) {
     @each $query in $queries {

diff --git a/hypha/static_src/sass/abstracts/_variables.scss b/hypha/static_src/sass/abstracts/_variables.scss
@@ -1,3 +1,5 @@
+// stylelint-disable scss/dollar-variable-pattern
+
 // Most variables are set from css variables defined in
 // tailwind/base/variables.css so they are easy to override.
 // Only variables used in media queries and calculations are defined here.

diff --git a/hypha/static_src/sass/base/_base.scss b/hypha/static_src/sass/base/_base.scss
@@ -1,6 +1,5 @@
 @use "../abstracts/variables";
 
-// stylelint-disable property-no-vendor-prefix
 body {
     overflow-x: hidden;
 

diff --git a/hypha/static_src/sass/components/_all-reviews-table.scss b/hypha/static_src/sass/components/_all-reviews-table.scss
@@ -1,8 +1,6 @@
 @use "../abstracts/mixins";
 @use "../abstracts/variables";
 
-// stylelint-disable selector-max-compound-selectors
-
 .all-reviews-table {
     @include mixins.table-ordering-styles;
 

diff --git a/hypha/static_src/sass/components/_all-submissions-table.scss b/hypha/static_src/sass/components/_all-submissions-table.scss
@@ -1,7 +1,7 @@
 @use "../abstracts/mixins";
 @use "../abstracts/variables";
 
-// stylelint-disable selector-class-pattern,selector-max-compound-selectors
+// stylelint-disable selector-class-pattern
 
 .all-submissions-table {
     @include mixins.table-ordering-styles;
@@ -177,7 +177,6 @@
                 }
             }
 
-            // stylelint-disable-next-line force-element-nesting
             > span.mobile-label {
                 display: inline-block;
                 width: 90px;

diff --git a/hypha/static_src/sass/components/_button.scss b/hypha/static_src/sass/components/_button.scss
@@ -62,7 +62,6 @@
     }
 
     &--login {
-        /* stylelint-disable-next-line media-query-no-invalid */
         @media (min-width: variables.$input-box-max-width) {
             width: 20rem;
         }

diff --git a/hypha/static_src/sass/components/_dashboard-table.scss b/hypha/static_src/sass/components/_dashboard-table.scss
@@ -1,8 +1,6 @@
 @use "../abstracts/mixins";
 @use "../abstracts/variables";
 
-// stylelint-disable selector-max-compound-selectors
-
 .paf-review-table {
     @include mixins.table-ordering-styles;
 
@@ -41,7 +39,6 @@
 
     tbody {
         td {
-            // stylelint-disable-next-line force-element-nesting
             > span.mobile-label {
                 display: inline-block;
                 width: 90px;

diff --git a/hypha/static_src/sass/components/_feed.scss b/hypha/static_src/sass/components/_feed.scss
@@ -134,7 +134,6 @@
 
             span {
                 &:first-child {
-                    // stylelint-disable-next-line max-nesting-depth
                     &::after {
                         @include mixins.triangle(
                             right,

diff --git a/hypha/static_src/sass/components/_form.scss b/hypha/static_src/sass/components/_form.scss
@@ -1,9 +1,6 @@
 @use "../base/base";
 @use "../abstracts/mixins";
 @use "../abstracts/variables";
-
-// stylelint-disable selector-max-compound-selectors
-
 @use "sass:math";
 
 .form {
@@ -260,7 +257,6 @@
                 }
 
                 input {
-                    // stylelint-disable-next-line max-nesting-depth
                     &:first-of-type {
                         @supports (display: grid) {
                             grid-column: 1;
@@ -455,7 +451,7 @@
     }
 
     &__comments {
-        // stylelint-disable-next-line selector-class-pattern,selector-id-pattern,selector-max-id
+        // stylelint-disable-next-line selector-class-pattern,selector-id-pattern
         ul#id_visibility {
             display: flex;
             flex-wrap: wrap;
@@ -487,7 +483,7 @@
 
     .address {
         padding: 0.4em;
-        border: 1px solid #cfcfcf8f; // stylelint-disable-line color-no-hex
+        border: 1px solid #cfcfcf8f;
         max-width: 410px;
 
         // stylelint-disable-next-line selector-class-pattern

diff --git a/hypha/static_src/sass/components/_nprogress.scss b/hypha/static_src/sass/components/_nprogress.scss
@@ -1,6 +1,6 @@
 @use "../abstracts/variables";
 
-/* stylelint-disable selector-max-id, length-zero-no-unit -- CSS from https://github.com/rstacruz/nprogress */
+/* stylelint-disable length-zero-no-unit -- CSS from https://github.com/rstacruz/nprogress */
 #nprogress {
     /* Make clicks pass-through */
     pointer-events: none;

diff --git a/hypha/static_src/sass/components/_projects-table.scss b/hypha/static_src/sass/components/_projects-table.scss
@@ -1,8 +1,6 @@
 @use "../abstracts/mixins";
 @use "../abstracts/variables";
 
-// stylelint-disable selector-max-compound-selectors
-
 .projects-table {
     @include mixins.table-ordering-styles;
 
@@ -16,7 +14,6 @@
 
     tbody {
         td {
-            // stylelint-disable-next-line force-element-nesting
             > span.mobile-label {
                 display: inline-block;
                 width: 90px;
@@ -62,7 +59,6 @@
 
     tbody {
         td {
-            // stylelint-disable-next-line force-element-nesting
             > span.mobile-label {
                 display: inline-block;
                 width: 90px;

diff --git a/hypha/static_src/sass/components/_reviews-sidebar.scss b/hypha/static_src/sass/components/_reviews-sidebar.scss
@@ -1,8 +1,6 @@
 @use "../abstracts/mixins";
 @use "../abstracts/variables";
 
-// stylelint-disable max-nesting-depth
-
 .reviews-sidebar {
     $root: &;
     margin-block-end: 20px;

diff --git a/hypha/static_src/sass/components/_select2.scss b/hypha/static_src/sass/components/_select2.scss
@@ -1,7 +1,7 @@
 @use "../abstracts/mixins";
 @use "../abstracts/variables";
 
-// stylelint-disable selector-max-compound-selectors, selector-class-pattern
+// stylelint-disable selector-class-pattern
 
 .select2 {
     &-container {
@@ -10,7 +10,6 @@
 
     .select2-container--default,
     &.select2-container--default {
-        // stylelint-disable-next-line declaration-no-important
         width: 100% !important;
 
         .select2-selection--single {
@@ -58,9 +57,7 @@
 .select2-container {
     &--default {
         .select2-results__option--highlighted[aria-selected] {
-            // stylelint-disable-next-line declaration-no-important
             color: variables.$color--default !important;
-            // stylelint-disable declaration-no-important, max-line-length
             background-color: variables.$color--light-blue-90 !important;
         }
     }

diff --git a/hypha/static_src/sass/components/_submission-meta.scss b/hypha/static_src/sass/components/_submission-meta.scss
@@ -6,7 +6,6 @@
     tbody {
         td {
             &.phase {
-                // stylelint-disable-next-line selector-max-compound-selectors
                 span {
                     display: inline-block;
                     padding: 10px;

diff --git a/hypha/static_src/sass/components/_table.scss b/hypha/static_src/sass/components/_table.scss
@@ -1,8 +1,6 @@
 @use "../abstracts/mixins";
 @use "../abstracts/variables";
 
-// stylelint-disable selector-max-compound-selectors,max-nesting-depth
-
 .table-container {
     > table {
         border: 1px solid variables.$color--light-mid-grey;

diff --git a/hypha/static_src/sass/components/_tabs.scss b/hypha/static_src/sass/components/_tabs.scss
@@ -50,7 +50,7 @@
             background-color: rgba(
                 #fff,
                 0.8
-            ); // stylelint-disable-line color-no-hex
+            );
         }
 
         &--alt {

diff --git a/hypha/static_src/sass/components/_two-factor.scss b/hypha/static_src/sass/components/_two-factor.scss
@@ -1,4 +1,4 @@
-// stylelint-disable property-no-vendor-prefix, selector-id-pattern, selector-max-id
+// stylelint-disable property-no-vendor-prefix, selector-id-pattern
 @use "../base/typography";
 
 .two-factor {

diff --git a/hypha/static_src/sass/print.scss b/hypha/static_src/sass/print.scss
@@ -1,4 +1,3 @@
-// stylelint-disable color-no-hex, no-color-literals, declaration-no-important
 // stylelint-disable property-no-vendor-prefix, selector-class-pattern
 * {
     background: transparent !important;

diff --git a/hypha/static_src/sass/wagtail_users_list.scss b/hypha/static_src/sass/wagtail_users_list.scss
@@ -1,3 +1,5 @@
+// stylelint-disable media-feature-range-notation
+
 .users-list {
     padding-inline-start: 1rem;
     padding-inline-end: 1rem;
-Original file line number
+Diff line change
@@ Expand Up / @@ -50,7 +50,7 @@ @@
                 background-color: rgba(
                     #fff,
 .8
-                ); // stylelint-disable-line color-no-hex
+                );
             }
             &--alt {
@@ Expand Down @@