All view port to mobile -- response #197
Draft
+363
−357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor from what you have in your branch @thomasgwatson. Some simple tidy-up and fixes, but also several larger moves here which I do care a fair amount about us making or at least genuinely considering as I do think we need things better factored here to avoid some traps coming in the next steps. I feel much less picky about what happens as we move up the layers from there. . Give it a look and see if you follow. I expect there is a thing or two here not quite right or lost in translation.
What's happening here in this PR branch:
iconName
,avatarUrl
, anddisplayName
into the ContextWidgetPresenter and then uses these static values in the two WidgetIcon components which does greatly simplify them (nearly making them unnecessary)_presented
flag to an already presented widget object and checks for that on run of ContextWidgetPresenter(unknownWidget) so we never try and double transform a widget. This allows us FOR NOW to still be lazy about deciding when and if we present a widget and don't need to worry about over doing it if we're not sure it was already presented.CustomViewPresenter
for later elaboration as needed, currently only holds the staticCOMMON_VIEWS
objectwidget?.attribute
vsconst { attribute } = widget
in a few placesAnd there are still 3-4 or things I'd like to iron out here, but if we can meet in this version then I can deal with those things... Please let's talk if I'm losing you here. I would still really like to be pair on these pieces until we're both feeling settled, and then dive into the remaining react navigation stuff to get us fully into the context menu setup until a point you can set sail again into that work?