Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-1862: Improve SDK coverage and data flow #6993

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex robot-ci-heartex commented Jan 29, 2025

Hi @robot-ci-heartex!

This PR was automaticaly generated via Follow Merge.
Please ensure that all linked upstream Pull Requests are merged before proceeding with this one.

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit e0e1243
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/679a8fa62d29350008468f51

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit e0e1243
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/679a8fa6ab14eb000936b755

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.90%. Comparing base (d7bac84) to head (e0e1243).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6993   +/-   ##
========================================
  Coverage    76.90%   76.90%           
========================================
  Files          175      175           
  Lines        14162    14166    +4     
========================================
+ Hits         10891    10895    +4     
  Misses        3271     3271           
Flag Coverage Δ
pytests 76.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot-ci-heartex robot-ci-heartex marked this pull request as ready for review January 29, 2025 20:31


@pytest.fixture
def test_project_with_view(django_live_url, business_client):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to have these as fixtures now with the current way we use pytest, but looking forward to progressively replacing them with something like Factory Boy when available (cc @mcanu )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants