Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better iPad compatibility #1982

Open
PhilipMay opened this issue Jan 30, 2022 · 23 comments
Open

Better iPad compatibility #1982

PhilipMay opened this issue Jan 30, 2022 · 23 comments
Assignees

Comments

@PhilipMay
Copy link

PhilipMay commented Jan 30, 2022

I would like to request a better iPad compatibility.

The "Submit" button should be much more left (se screenshot below). That way you could zoom in and handling would be easier.

Label Studio

@dentalala
Copy link

Do I understand correctly, you would like to zoom in a bit to see everything bigger, and when you do that, the Submit button goes out of the screen viewport? Thank you for that issue, we're working on the problem.

@PhilipMay
Copy link
Author

Do I understand correctly, you would like to zoom in a bit to see everything bigger, and when you do that, the Submit button goes out of the screen viewport? Thank you for that issue, we're working on the problem.

That is correct. And an improvement would be super nice.

@PhilipMay
Copy link
Author

I was also thinking of a "one click mode" where you do not 1. select the radio button and 2. submit.

What about one single button you can click, then you get a short visual feedback and after 0.5 sec. the formular
gets submitted?

@makseq makseq added feature Feature request labeling labels Feb 3, 2022
@dentalala
Copy link

What about one single button you can click, then you get a short visual feedback and after 0.5 sec. the formular
gets submitted?

That's an interesting idea which makes sense in many cases of labeling with choices.

@madhavajay
Copy link

I am trying to load this on my iPad Air 5. My segmentation projects in label studio 1.5.0 simply wont load on either Safari or Chrome on iPad or iPhone, it just shows a resizing box loading animation. Is this supported? I would love to do brush segmentation with the iPad pencil.

@makseq
Copy link
Member

makseq commented Jul 4, 2022

Try to use the latest develop branch please.

@hlomzik
Copy link
Collaborator

hlomzik commented Jul 5, 2022

We fixed problem with Safari, turned out that it doesn't support regexps fully

@makseq
Copy link
Member

makseq commented Jul 5, 2022

Please try to use develop branch again.

@madhavajay
Copy link

@makseq same error. I removed all image layers, rebuilt a second time to be sure, cleared my cache, tried desktop and ipad... Safari still giving the same regex error.

Any chance you can provide instructions on running in dev mode without minification and with hot reloading and I can probably fix this myself.

@makseq
Copy link
Member

makseq commented Jul 5, 2022

Could you please use the develop image from our dockerhub directly? heartexlabs/label-studio:develop

@madhavajay
Copy link

@makseq that does load. Weird, any idea why my build from the branch didn't work.
Only issue now is you can't really use it for brush labelling but I guess thats a seperate issue. Any idea if you have that on the roadmap. Adding something like the Apple Pencil JS API here: https://codesandbox.io/s/qr4uq

Right now the only solution I have that has half decent lag is to use parallels remote desktop to my main machine, but its definitely sub par.

I think all the scroll touch stuff needs changing and then the canvas needs to detect the pen and it would be amazing!

@makseq
Copy link
Member

makseq commented Jul 7, 2022

any idea why my build from the branch didn't work

you have to build frontend libs using

make frontend-build

then build a docker image.

No, we don't have this feature in our roadmap, because there are not so many requests about it.

@madhavajay
Copy link

@makseq are you able point to some instructions where I can start the frontend in dev mode so I can make changes so I can possibly give it a shot myself and then provide a PR?

@makseq
Copy link
Member

makseq commented Jul 8, 2022

@madhavajay Sure, you can start from this repo and instructions: https://github.com/heartexlabs/label-studio-frontend#development

@madhavajay
Copy link

@makseq I kind of got it working:
HumanSignal/label-studio-frontend#802

@makseq
Copy link
Member

makseq commented Aug 9, 2022

@madhavajay Amazing! I've asked our frontend team to review &merge this!

@makseq
Copy link
Member

makseq commented Aug 12, 2022

@madhavajay if you could make a PR in the main label-studio repo with LSF builds, it would be great :-)

@madhavajay
Copy link

@makseq should we wait for the frontend pr to be checked and merged first incase it introduces some bugs?

@makseq
Copy link
Member

makseq commented Aug 12, 2022

I think you can make a build from the LSF PR without merging it to develop. Does it make sense?

@madhavajay
Copy link

@makseq do you mean create a PR on this repo with the updated files just for people to use but not to merge?

@makseq
Copy link
Member

makseq commented Aug 14, 2022

yes!

@Garstig
Copy link

Garstig commented Aug 17, 2022

@madhavajay thanks for your contribution!

@makseq: please ping me when it is ready for tests :)

@shantanudev
Copy link

Any progress on this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants