Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brush labelling project won't load on iOS #2593

Closed
madhavajay opened this issue Jul 2, 2022 · 10 comments
Closed

Brush labelling project won't load on iOS #2593

madhavajay opened this issue Jul 2, 2022 · 10 comments
Assignees
Labels
labeling problem bug or something isn't working

Comments

@madhavajay
Copy link

Describe the bug

My segmentation projects in label studio 1.5.0 simply wont load on either Safari or Chrome on iPad or iPhone, it just shows a resizing box loading animation. Is this supported? I would love to do brush segmentation with the iPad pencil.

This is on both iPhone and iPad in Safari and Chrome (as well as Request Desktop Mode)

To Reproduce
Steps to reproduce the behavior:

  1. Go to a brush labelling project

Expected behavior
It should load.

Screenshots
If applicable, add screenshots to help explain your problem.
IMG_46575C7A3852-1

Environment (please complete the following information):

  • OS: iOS 15, iPhone and iPad Safari and Chrome
  • Label Studio Version: 1.5.0 docker container

Additional context
Add any other context about the problem here.

@madhavajay
Copy link
Author

This must be a bug in 1.5.0 because 1.4.1 is loading, however I cannot draw with the apple pencil.
This example seems to work though:
https://codesandbox.io/s/qr4uq

@makseq
Copy link
Member

makseq commented Jul 4, 2022

@madhavajay check the latest develop version of LS from the develop branch, it should be fixed there.

@makseq makseq closed this as completed Jul 4, 2022
@makseq makseq added problem bug or something isn't working labeling labels Jul 4, 2022
@madhavajay
Copy link
Author

Hi @makseq its still not working. I tried in incognito to make sure the .js isn't cached. In the safari remote debugger I see an error.

Screen Shot 2022-07-04 at 11 24 47 pm

Unfortunately due to all the minification it's not possible to see the line. Is there a way I can run the container in dev mode without source minification and say hot reloading so I can debug it?

@makseq
Copy link
Member

makseq commented Jul 22, 2022

@madhavajay please try pip install label-studio==1.5.0.post0

@madhavajay
Copy link
Author

@makseq I guess this can be closed since it loads, but I have a seperate issue relating to being able to use it.

@Garstig
Copy link

Garstig commented Aug 12, 2022

Hi @makseq,

for me it does not work at all on IPad. I tried to start a segmentation project but I can't use the brush since every touch only scrolls the app. Does not matter if I use my finger or the pencil.

pip freeze output:

label-studio==1.5.0.post0
label-studio-converter==0.0.40
label-studio-tools==0.0.0.dev14
launchdarkly-server-sdk==7.3.0

Should I open a new issue?

@makseq
Copy link
Member

makseq commented Aug 12, 2022

@Garstig #1982 (comment) --- we have this issue about your problem. Also we are preparing a fix with one of our contributors. If you want, we can ping you when it's ready for tests. Let me know in this issue - #1982

@madhavajay
Copy link
Author

@Garstig also, you can see my temporary fix here:
HumanSignal/label-studio-frontend#802

Just build that frontend code with build-bundle and copy it into the label-studio checkout and build the container.

@Garstig
Copy link

Garstig commented Aug 22, 2022

hi @madhavajay,

I just tried to build your temporary fix, but actually I have no real clue on how to do so since I am very unexperienced with frontend stuff. Could you review the steps I tried and please guide me in what to try next?

  • I cloned https://github.com/heartexlabs/label-studio-frontend and updated your file as you did in your PR. (A quick google research didn't give me a way to clone from a PR).
  • Then I thought I probably need to install npm packages to build it. So I did it with npm install --force (without --force I had dependency issues)
  • Then I installed build-bundle with "npm install --save build-bundle" but the package is not found. when I try to use it.

@haofengsiji
Copy link

haofengsiji commented Oct 10, 2022

hi @madhavajay,

I just tried to build your temporary fix, but actually I have no real clue on how to do so since I am very unexperienced with frontend stuff. Could you review the steps I tried and please guide me in what to try next?

  • I cloned https://github.com/heartexlabs/label-studio-frontend and updated your file as you did in your PR. (A quick google research didn't give me a way to clone from a PR).
  • Then I thought I probably need to install npm packages to build it. So I did it with npm install --force (without --force I had dependency issues)
  • Then I installed build-bundle with "npm install --save build-bundle" but the package is not found. when I try to use it.

It can be tested on this branch "https://github.com/heartexlabs/label-studio/tree/fb-dev-3132-brush-ipad". It is truly a fantastic feature. But still, need to be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labeling problem bug or something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants