This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-580: Display non-string values in Text #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During recent incident fix we missed conversion to string for Text tag's `value` param.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1675 +/- ##
==========================================
- Coverage 64.60% 64.60% -0.01%
==========================================
Files 443 443
Lines 28730 28730
Branches 7526 7526
==========================================
- Hits 18561 18560 -1
- Misses 10169 10170 +1 ☔ View full report in Codecov by Sentry. |
juliosgarbi
approved these changes
Jan 23, 2024
|
/git merge master
|
hlomzik
changed the title
hlomzik
changed the title
hlomzik
added a commit
that referenced
this pull request
Jan 23, 2024
* Fix: LEAP-580: Display non-string values in Text During recent incident fix we missed conversion to string for Text tag's `value` param. * Fix deprecated `substr` to `slice` in `parseValue` * Add cypress test for non-string values --------- Co-authored-by: hlomzik <[email protected]>
This was referenced Jan 23, 2024
hlomzik
added a commit
that referenced
this pull request
Jan 23, 2024
fix: LEAP-580: Display non-string values in Text (#1675) * Fix: LEAP-580: Display non-string values in Text During recent incident fix we missed conversion to string for Text tag's `value` param. * Fix deprecated `substr` to `slice` in `parseValue` * Add cypress test for non-string values --------- Co-authored-by: hlomzik <[email protected]>
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
* Fix: LEAP-580: Display non-string values in Text During recent incident fix we missed conversion to string for Text tag's `value` param. * Fix deprecated `substr` to `slice` in `parseValue` * Add cypress test for non-string values --------- Co-authored-by: hlomzik <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During recent incident fix we missed conversion to string for Text tag's
valueparam.Fixing it back!
PR fulfills these requirements
Describe the reason for change
Non-string values can be very helpful in different cases, for example to display meta info like prices, flags, etc.
What feature flags were used to cover this change?
fflag_fix_leap_466_text_sanitization— but this flag should never be false and will be removed soon.This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?
parseValuewere fixed to replace deprecated function