Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-344: View all annotation tab is not loading #1657

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

juliosgarbi
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

The "View All Annotations" tab was experiencing loading issues when accessed with a configuration containing an image. The problem stemmed from the validation process, which was impeded by the lazy loading behavior of the image tag. As a result, the image wasn't added to the viewport until fully loaded, causing the tab to fail to load.

What does this fix?

To address this issue, the fix involves skipping the validation if the image is marked as ready. This modification acknowledges the lazy load behavior of the image, ensuring that the validation process doesn't impede the loading of the "View All Annotations" tab.

What libraries were added/updated?

None

Does this change affect performance?

no

Does this change affect security?

no

What alternative approaches were there?

Consideration was given to removing the lazy load from the ImageView to directly address the loading issues. However, it's crucial to note that this alternative approach comes with potential performance degradation.

What feature flags were used to cover this change?

no

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Grid

@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Jan 3, 2024

/git merge master

Workflow run
Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-344 (0ae0bd6)

@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Jan 8, 2024

/git merge master

Workflow run
Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-344 (ddb613a)

@juliosgarbi juliosgarbi enabled auto-merge (squash) January 8, 2024 11:27
@juliosgarbi juliosgarbi merged commit eb1194c into master Jan 8, 2024
12 of 13 checks passed
@juliosgarbi juliosgarbi deleted the fb-leap-344 branch January 8, 2024 12:48
MasherJames pushed a commit to HelloPareto/label-studio-frontend that referenced this pull request Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants