This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-344: View all annotation tab is not loading #1657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
The "View All Annotations" tab was experiencing loading issues when accessed with a configuration containing an image. The problem stemmed from the validation process, which was impeded by the lazy loading behavior of the image tag. As a result, the image wasn't added to the viewport until fully loaded, causing the tab to fail to load.
What does this fix?
To address this issue, the fix involves skipping the validation if the image is marked as ready. This modification acknowledges the lazy load behavior of the image, ensuring that the validation process doesn't impede the loading of the "View All Annotations" tab.
What libraries were added/updated?
None
Does this change affect performance?
no
Does this change affect security?
no
What alternative approaches were there?
Consideration was given to removing the lazy load from the ImageView to directly address the loading issues. However, it's crucial to note that this alternative approach comes with potential performance degradation.
What feature flags were used to cover this change?
no
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Grid