Remove deprecated numpy attributes #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itwasabhi
force-pushed
the
update_np_inf
branch
from
1a012b7 to
0b85561
Compare
Changes np.Inf to np.inf and np.int to int. Users may get a attribute error on using np.Inf for newer numpy versions. This should be a non-breaking change since np.inf is available in older numpy versions (and already used across this repo).
itwasabhi
force-pushed
the
update_np_inf
branch
from
0b85561 to
dd0e570
Compare
itwasabhi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users may get a attribute error on using np.Inf for newer numpy versions. This should be a non-breaking change since np.inf is available in older numpy versions (and already used across this repo).
Fixes #149
Type of change
Checklist: