Binary search tree on JS #12
Conversation
| if (this.leftChild !== null) { | ||
| this.leftChild.output(); | ||
| } | ||
| console.dir(this.data); |
There was a problem hiding this comment.
I think it should be console.log() instead of console.dir(). This works too, yeah, but console.log() would be more idiomatic.
| current = current.leftChild; | ||
| } | ||
| return current; | ||
| } else return null; |
There was a problem hiding this comment.
I'd find it more readable to use braces in the else clause when you use them in the if clause generally. In this specific case you don't need else at all though.
There was a problem hiding this comment.
It may also be worth to invert the condition and return null early to reduce the level of indentation of the following block of code.
| current = current.rightChild; | ||
| } | ||
| return current; | ||
| } else return null; |
| BinarySearchTree.prototype.insert = function(data) { | ||
| if (this.root !== null) { | ||
| this.root.insert(data); | ||
| } else this.root = new Node(null, data); |
| console.log('Search node 13: ' + tree.search(13) + ': ' + tree.search(13).data); | ||
| console.log('Search node 11: ' + tree.search(11)); | ||
|
|
||
| //tree.delete(15); |
There was a problem hiding this comment.
Is it intentional that these lines are commented out?
| while (current.leftChild !== null) { | ||
| current = current.leftChild; | ||
| } | ||
| return current; |
There was a problem hiding this comment.
I believe returning current.data makes more sense both here and in BinarySearchTree.prototype.max(). Node instances are an implementation detail, let's encapsulate them away.
No description provided.