#152 [fix] todo, badge QA 반영 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/#152-adapt-todo-qa
murjune
approved these changes
Dec 7, 2022
Comment on lines
+20
to
+27
| class MemberTodoMapperTest { | ||
| private val mockTodoEntity = ToDoEntity( | ||
| isChecked = false, | ||
| todoId = 1, | ||
| todoName = "테스트", | ||
| nicknames = listOf("KWY"), | ||
| status = null | ||
| ) |
There was a problem hiding this comment.
아 계속 mapper 에러 나서 답답해서 에러 찾으려고 만들었는데,
clean project 했더니 사라진 오류... 😢
잃어버린 내 1시간...
murjune
approved these changes
Dec 7, 2022
| @@ -78,6 +78,7 @@ class DailyFragment : BindingFragment<FragmentDailyBinding>(R.layout.fragment_da | |||
| ) | |||
| } | |||
| } | |||
| delay(10) | |||
There was a problem hiding this comment.
근데 저는 이거 지워도 잘 동작하는거 같은데용..??
무슨 문제일까요 ㅜ
There was a problem hiding this comment.
혹시 라이프 사이클 문제는 아닐까 싶은데 뷰가 그려지기 전에 이게 동작한거라면 안먹지 않을까 싶어서... 딜레이를 줌으로써 뷰가 그려진 후의 라이프사이클에 들어간 것이 아닐까...
yjooooo
approved these changes
Dec 7, 2022
| @@ -78,6 +78,7 @@ class DailyFragment : BindingFragment<FragmentDailyBinding>(R.layout.fragment_da | |||
| ) | |||
| } | |||
| } | |||
| delay(10) | |||
There was a problem hiding this comment.
혹시 라이프 사이클 문제는 아닐까 싶은데 뷰가 그려지기 전에 이게 동작한거라면 안먹지 않을까 싶어서... 딜레이를 줌으로써 뷰가 그려진 후의 라이프사이클에 들어간 것이 아닐까...
Comment on lines
+70
to
+72
| enum class TodoState { | ||
| IDLE, PROGRESS | ||
| } |
There was a problem hiding this comment.
ui 단에서만 쓰이는 거라서 여기에 선언했습니다..!
…to feature/#152-adapt-todo-qa # Conflicts: # app/src/main/java/hous/release/android/presentation/todo/detail/daily/DailyFragment.kt # app/src/main/java/hous/release/android/presentation/todo/detail/member/MemberFragment.kt
2zerozu
approved these changes
Dec 7, 2022
| @@ -78,6 +78,7 @@ class DailyFragment : BindingFragment<FragmentDailyBinding>(R.layout.fragment_da | |||
| ) | |||
| } | |||
| } | |||
| delay(10) | |||
Comment on lines
+20
to
+27
| class MemberTodoMapperTest { | ||
| private val mockTodoEntity = ToDoEntity( | ||
| isChecked = false, | ||
| todoId = 1, | ||
| todoName = "테스트", | ||
| nicknames = listOf("KWY"), | ||
| status = null | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
KakaoTalk_20221206_052454726.mp4
작업한 내용
PR 포인트
viewpager의 뷰 구현이 느린지,
currItem = uiState.tabindex이게 안 먹습니다.그래서 delay(10)을 줬다는... ㅠ_ㅠ
위 delay 문제랑 이 문제 때문에 activity에 멤버별 보기, 요일별 보기 뷰를 visible, unvisible로 바꿀지...고민입니다....