-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows/tests: set HOMEBREW_LIVECHECK_AUTOBUMP #203209
Conversation
33f35b6
to
c984633
Compare
Looks like this works as expected (https://github.com/Homebrew/homebrew-core/actions/runs/12612343215/job/35149025577?pr=203209), so I dropped the
|
maybe due to #203203 merge |
We recently modified the behavior of `brew livecheck` to skip packages in the tap's autobump list, so this change is causing autobumped formulae to fail the `brew livecheck` part of CI testing. This adds the `HOMEBREW_LIVECHECK_AUTOBUMP` ENV variable, which will ensure that `brew livecheck` doesn't skip autobumped formulae (without manually passing the `--autobump` flag).
c984633
to
3ecc7d2
Compare
hmm, still failed with |
@@ -241,6 +241,7 @@ jobs: | |||
--added-formulae="$ADDED_FORMULAE" \ | |||
--deleted-formulae="$DELETED_FORMULAE" | |||
env: | |||
HOMEBREW_LIVECHECK_AUTOBUMP: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like something that should be set in test-bot
instead of here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure which would be preferable but that makes sense to me. One moment and I'll open a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is now up at Homebrew/homebrew-test-bot#1353 and I've set this one as a draft. I'll close this PR if/when we go forward with the test-bot approach.
the test-bot pr got merged, and now the flyctl pr works fine now, thanks @samford! |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?We recently modified the behavior of
brew livecheck
to skip packages in the tap's autobump list, so this change is causing autobumped formulae to fail thebrew livecheck
part of CI testing. This adds theHOMEBREW_LIVECHECK_AUTOBUMP
ENV variable, which will ensure thatbrew livecheck
doesn't skip autobumped formulae (without manually passing the--autobump
flag).I've pulled in the
flyctl
bump commit to make sure this works as expected.