Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/tests: set HOMEBREW_LIVECHECK_AUTOBUMP #203209

Closed
wants to merge 1 commit into from

Conversation

samford
Copy link
Member

@samford samford commented Jan 4, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We recently modified the behavior of brew livecheck to skip packages in the tap's autobump list, so this change is causing autobumped formulae to fail the brew livecheck part of CI testing. This adds the HOMEBREW_LIVECHECK_AUTOBUMP ENV variable, which will ensure that brew livecheck doesn't skip autobumped formulae (without manually passing the --autobump flag).

I've pulled in the flyctl bump commit to make sure this works as expected.

@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Jan 4, 2025
@samford samford force-pushed the workflows/tests-set-livecheck-autobump-env branch from 33f35b6 to c984633 Compare January 4, 2025 17:28
@samford samford marked this pull request as ready for review January 4, 2025 17:28
@samford samford requested review from MikeMcQuaid and a team as code owners January 4, 2025 17:28
@samford
Copy link
Member Author

samford commented Jan 4, 2025

Looks like this works as expected (https://github.com/Homebrew/homebrew-core/actions/runs/12612343215/job/35149025577?pr=203209), so I dropped the flyctl commit. Not sure why the actionlint check is failing:

Error: cannot load such file -- regexp_parser
Warning: Removed Sorbet lines from backtrace!
<internal:/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
<internal:/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/json_schemer-2.3.0/lib/json_schemer.rb:12:in `<top (required)>'
<internal:/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
<internal:/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/extend/kernel.rb:11:in `require?'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/sbom.rb:90:in `schema_validation_errors'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/sbom.rb:104:in `valid?'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/sbom.rb:121:in `write'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:900:in `finish'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:821:in `install_dependency'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:737:in `block in install_dependencies'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:737:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:737:in `install_dependencies'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:463:in `install'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/upgrade.rb:213:in `install_formula'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/install.rb:361:in `install_formula'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/install.rb:313:in `block in install_formulae'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/install.rb:312:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/install.rb:312:in `install_formulae'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/install.rb:301:in `run'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:94:in `<main>'

@chenrui333
Copy link
Member

maybe due to #203203 merge

We recently modified the behavior of `brew livecheck` to skip
packages in the tap's autobump list, so this change is causing
autobumped formulae to fail the `brew livecheck` part of CI testing.
This adds the `HOMEBREW_LIVECHECK_AUTOBUMP` ENV variable, which
will ensure that `brew livecheck` doesn't skip autobumped formulae
(without manually passing the `--autobump` flag).
@samford samford force-pushed the workflows/tests-set-livecheck-autobump-env branch from c984633 to 3ecc7d2 Compare January 4, 2025 17:33
@chenrui333
Copy link
Member

hmm, still failed with Error: cannot load such file -- regexp_parser

@@ -241,6 +241,7 @@ jobs:
--added-formulae="$ADDED_FORMULAE" \
--deleted-formulae="$DELETED_FORMULAE"
env:
HOMEBREW_LIVECHECK_AUTOBUMP: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like something that should be set in test-bot instead of here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure which would be preferable but that makes sense to me. One moment and I'll open a PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is now up at Homebrew/homebrew-test-bot#1353 and I've set this one as a draft. I'll close this PR if/when we go forward with the test-bot approach.

@samford samford marked this pull request as draft January 4, 2025 17:43
@chenrui333
Copy link
Member

the test-bot pr got merged, and now the flyctl pr works fine now, thanks @samford!

@chenrui333 chenrui333 closed this Jan 4, 2025
@chenrui333 chenrui333 deleted the workflows/tests-set-livecheck-autobump-env branch January 4, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants