Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl-dbd-mysql 5.010 (new formula) #202845

Merged
merged 6 commits into from
Jan 16, 2025
Merged

perl-dbd-mysql 5.010 (new formula) #202845

merged 6 commits into from
Jan 16, 2025

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 31, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Considering exception to CPAN formula policy to reduce propagating workarounds for DBD::mysql in multiple formulae.

Mainly 2 workarounds for macOS perl:

  • Fixup of Makefile due to Apple's wonky installation of DBI (Apple split the install up but didn't fix the paths).
  • -dead_strip_dylibs to avoid zlib/etc linkage

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core perl Perl use is a significant feature of the PR or issue labels Dec 31, 2024
Formula/p/perl-dbd-mysql.rb Outdated Show resolved Hide resolved
@cho-m cho-m added the maintainer feedback Additional maintainers' opinions may be needed label Dec 31, 2024
@cho-m cho-m force-pushed the perl-dbd-mysql branch 2 times, most recently from 7b34bb5 to 57b500b Compare December 31, 2024 17:26
@cho-m cho-m marked this pull request as ready for review December 31, 2024 17:46
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense 👍

Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this to reduce build cost

@cho-m cho-m removed the maintainer feedback Additional maintainers' opinions may be needed label Jan 16, 2025
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 16, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 16, 2025 16:24
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit 7f9e201 Jan 16, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the perl-dbd-mysql branch January 16, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core perl Perl use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants