netatalk 4.0.8 (new formula)

[rdmark]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>? (see caveat below)

---

Please note that brew audit --new netatalk throws non-compliance as per the below. However, the native macOS berkeley-db and openldap libraries are both unusable: The former lacks required symbols, and the latter (represented by LDAP.Framework) isn't fork safe while netatalk is a forking application.

brew audit --new netatalk                                                  
netatalk
  * Dependency 'berkeley-db' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.
  * Dependency 'openldap' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.

[github-actions]

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

[rdmark]

The remaining CI failures are triggered by the brew audit checks, AFAICT.

As mentioned in the summary, complying with them and using the macOS supplied libraries will break the software. Can these CI failures be ignored?

[carlocab]

Thanks for the PR; a few comments.

[rdmark]

@carlocab Thanks for all your help! I'm pleased that we got it working in the end.

FYI, I had to force-push the branch again because one of the macOS CI runners got flaky and posted a failure. Seems to have been an intermittent connection issue with the runner machine. Hopefully we get a green slate this time...

Edit: All jobs passed this time!

[rdmark]

I figured out how to register the launchd / systemd services for netatalk. It basically works, if you invoke brew services with sudo. However I'm on the fence about whether it's worth adding or not, because brew services is clearly designed to be run as non-root, so I'm getting various warnings and errors.

diff --git a/Formula/n/netatalk.rb b/Formula/n/netatalk.rb
index 7258a9604f7..8fff22103e7 100644
--- a/Formula/n/netatalk.rb
+++ b/Formula/n/netatalk.rb
@@ -45,7 +45,8 @@ class Netatalk < Formula
       "-Dwith-appletalk=#{OS.linux?}", # macOS doesn't have an AppleTalk stack
       "-Dwith-bdb-path=#{Formula["berkeley-db@5"].opt_prefix}",
       "-Dwith-docbook-path=#{Formula["docbook-xsl"].opt_prefix}/docbook-xsl",
-      "-Dwith-init-style=none",
+      "-Dwith-init-dir=#{prefix}",
+      "-Dwith-init-hooks=false",
       "-Dwith-install-hooks=false",
       "-Dwith-pam-config-path=#{etc}/pam.d",
       "-Dwith-rpath=false",
@@ -57,6 +58,10 @@ class Netatalk < Formula
     system "meson", "install", "-C", "build"
   end
 
+  service do
+    name macos: "io.netatalk.daemon", linux: "netatalk"
+  end
+
   test do
     system sbin/"netatalk", "-V"
     system sbin/"afpd", "-V"

[SMillerDev]

There is a requires_root for the service block for exactly that.

[rdmark]

@SMillerDev Right on, that did the trick. Thanks!

[carlocab]

What do these service files look like? In particular, where do they send logs, and what working directory do they use?

[EricFromCanada]

• macOS: https://github.com/Netatalk/netatalk/blob/main/distrib/initscripts/macos.netatalk.plist.in
  • logs to /tmp/netatalk.out and /tmp/netatalk.err
• Linux: https://github.com/Netatalk/netatalk/blob/main/distrib/initscripts/systemd.netatalk.service.in

[carlocab]

We probably want to fix up some of those path references, since they'll likely be Cellar paths that aren't suitable for long-lived services

[rdmark]

@carlocab So you're arguing that the two /tmp paths for the macOS logs should be rewritten to start with #{prefix}, for instance /opt/homebrew/Cellar/netatalk/4.0.8/var/log ?

Or am I getting your comment backwards?

[rdmark]

On Linux, we log to journald by default, and not to a particular file.

The working directory is not controlled by the service files, but rather the build system. On aarch64 macOS, for instance, the working directory is /opt/homebrew/Cellar/netatalk/4.0.8/var/netatalk.

[EricFromCanada]

The problem is the generated paths in the plist include the version number, e.g. /opt/homebrew/Cellar/netatalk/4.0.8/bin/netatalkd. The version-agnostic path to use would be /opt/homebrew/opt/netatalk/bin/netatalkd.