r*: Fix Homebrew/NoFileutilsRmrf RuboCop offenses
#179161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issyl0
added
the
CI-syntax-only
github-actions
bot
added
long build
chenrui333
approved these changes
Jul 31, 2024
chenrui333
removed
long build
let's maybe wait for #178436 to be merged first. |
chenrui333
force-pushed
the
r-rubocop-no-rmrf
branch
from
a42931a to
b73cb66
Compare
|
rebased per rust PR merge |
github-actions
bot
added
CI-build-dependents-from-source
chenrui333
removed
CI-build-dependents-from-source
scpeters
reviewed
Aug 1, 2024
| #{rubygems_bindir}/bundle | ||
| #{rubygems_bindir}/bundler | ||
| ] | ||
| rm_rf Dir[HOMEBREW_PREFIX/"lib/ruby/gems/#{api_version}/gems/bundler-*"] |
There was a problem hiding this comment.
calling brew install ruby now fails for me in this postinstall step if these files don't exist in rubygems_bindir. I think the -f to rm was allowing the operation to succeed even if the files don't exist, and now they can fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?There's Rust in this batch. 🦀 😬