Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uffizzi 2.4.1 #157649

Closed
wants to merge 1 commit into from
Closed

uffizzi 2.4.1 #157649

wants to merge 1 commit into from

Conversation

krehel
Copy link
Member

@krehel krehel commented Dec 18, 2023 •
edited by chenrui333
Loading

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.
release notes 
## What's Changed
* [388] updated upload artifacts workflow version by @moklidia in https://github.com/UffizziCloud/uffizzi_cli/pull/389

Full Changelog: UffizziCloud/uffizzi_cli@v2.4.0...v2.4.1

@github-actions github-actions bot added ruby Ruby use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Dec 18, 2023
@krehel @chenrui333
uffizzi 2.4.1
e5e2e51 
uffizzi: update deps

Signed-off-by: Rui Chen <[email protected]>
@iMichka
Copy link
Member

iMichka commented Dec 18, 2023

Some gem ressource versions got downgraded. How's that? activesupport, tzinfo, addressable, public_suffix

@chenrui333
Copy link
Member

chenrui333 commented Dec 18, 2023 •
edited
Loading

Some gem ressource versions got downgraded. How's that? activesupport, tzinfo, addressable, public_suffix

I just did whatever the gem list shows

$ gem install --explain uffizzi-cli
Gems to install:
  tty-cursor-0.7.1
  tty-spinner-0.9.3
  wisper-2.0.1
  tty-screen-0.8.2
  tty-reader-0.9.0
  tty-color-0.6.0
  pastel-0.8.0
  tty-prompt-0.23.1
  thor-1.2.1
  concurrent-ruby-1.2.2
  sentry-ruby-5.15.2
  securerandom-0.2.2
  minitar-0.9
  public_suffix-5.0.3
  addressable-2.8.4
  launchy-2.5.2
  i18n-1.14.1
  faker-3.2.2
  awesome_print-1.9.2
  minitest-5.17.0
  zeitwerk-2.6.6
  tzinfo-2.0.5
  activesupport-6.1.7
  uffizzi-cli-2.4.1

@chenrui333
Copy link
Member

Some gem ressource versions got downgraded. How's that? activesupport, tzinfo, addressable, public_suffix

I just did whatever the gem list shows

that also matches with what in the gem.lock file, https://github.com/UffizziCloud/uffizzi_cli/blob/develop/Gemfile.lock#L19

chenrui333
chenrui333 reviewed Dec 18, 2023
View reviewed changes
Formula/u/uffizzi.rb
Comment on lines 93 to 101
resource "public_suffix" do
url "https://rubygems.org/gems/public_suffix-5.0.4.gem"
sha256 "35cd648e0d21d06b8dce9331d19619538d1d898ba6d56a6f2258409d2526d1ae"
url "https://rubygems.org/gems/public_suffix-5.0.3.gem"
sha256 "337d475da2bd2ea1de0446751cb972ad43243b4b00aa8cf91cb904fa593d3259"
end

resource "addressable" do
url "https://rubygems.org/gems/addressable-2.8.5.gem"
sha256 "63f0fbcde42edf116d6da98a9437f19dd1692152f1efa3fcc4741e443c772117"
url "https://rubygems.org/gems/addressable-2.8.4.gem"
sha256 "40a88af5285625b7fb14070e550e667d5b0cc91f748068701b4d897cacda4897"
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not quite sure about why these got downgraded

chenrui333
chenrui333 reviewed Dec 18, 2023
View reviewed changes
Formula/u/uffizzi.rb
@@ -161,13 +161,13 @@ class Uffizzi < Formula
end

resource "activesupport" do
url "https://rubygems.org/gems/activesupport-7.1.2.gem"
sha256 "5bd81ef71524a14725ecb6c3b07bfc00ae0ccc77dd611190bd93bd9f92abd0d0"
url "https://rubygems.org/gems/activesupport-6.1.7.gem"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/UffizziCloud/uffizzi_cli/blob/develop/Gemfile.lock#L19

chenrui333
chenrui333 reviewed Dec 18, 2023
View reviewed changes
Formula/u/uffizzi.rb
@@ -66,8 +66,8 @@ class Uffizzi < Formula
end

resource "thor" do
url "https://rubygems.org/gems/thor-1.3.0.gem"
sha256 "1adc7f9e5b3655a68c71393fee8bd0ad088d14ee8e83a0b73726f23cbb3ca7c3"
url "https://rubygems.org/gems/thor-1.2.1.gem"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a bit off,

https://github.com/UffizziCloud/uffizzi_cli/blob/develop/Gemfile.lock#L105

@chenrui333 chenrui333 mentioned this pull request Dec 18, 2023
Open
@chenrui333
Copy link
Member

I guess we can use whatever latest, refreshed the upstream gem lockfile, UffizziCloud/uffizzi_cli#390

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Dec 21, 2023
@chenrui333 chenrui333 added in progress Stale bot should stay away upstream issue An upstream issue report is needed and removed stale No recent activity labels Dec 21, 2023
@chenrui333 chenrui333 closed this Dec 26, 2023
@krehel krehel deleted the bump-uffizzi-2.4.1 branch January 2, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` in progress Stale bot should stay away ruby Ruby use is a significant feature of the PR or issue upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krehel @iMichka @chenrui333