Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tomsfastmath formula, and use it for clamav #101420

Closed
wants to merge 2 commits into from

Conversation

triallax
Copy link
Contributor

@triallax triallax commented May 13, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See #100780 (comment).

The test I wrote fails on 12-arm64, but I can't reproduce locally. Help would be appreciated.

depends_on "libtool" => :build

# Fixes some issues in `makefile.shared`, remove on next release.
patch :DATA
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this patch were already done upstream, but a release with the changes hasn't been made yet.

desc "Fast large integer arithmetic library written in portable ISO C"
homepage "https://www.libtom.net/TomsFastMath/"
url "https://github.com/libtom/tomsfastmath/releases/download/v0.13.1/tfm-0.13.1.tar.xz"
sha256 "47c97a1ada3ccc9fcbd2a8a922d5859a84b4ba53778c84c1d509c1a955ac1738"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware that there should be a license here, but I'm not sure what to put. The current development branch is under the Unlicense, but the latest release (0.13.1) is dual-licensed under some custom public domain dedication and the WTFPL. See https://github.com/libtom/tomsfastmath/blob/v0.13.1/LICENSE.

What should I do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you ask for a release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My issue hasn't received any response, so I think we can put the dual license of the 0.13.1 release here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Is :public_domain appropriate for a custom public domain dedication?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jun 5, 2022
@triallax
Copy link
Contributor Author

triallax commented Jun 5, 2022

Bump, waiting for answers for my questions above.

@github-actions github-actions bot removed the stale No recent activity label Jun 5, 2022
@triallax triallax force-pushed the tomsfastmath-0.13.1 branch from 0cd60a1 to ee55917 Compare June 5, 2022 15:24
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jun 27, 2022
@triallax
Copy link
Contributor Author

Bump, again.

@github-actions github-actions bot removed the stale No recent activity label Jun 27, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 18, 2022
@triallax triallax force-pushed the tomsfastmath-0.13.1 branch from ee55917 to abc41e4 Compare July 18, 2022 16:49
@github-actions github-actions bot closed this Jul 26, 2022
@triallax
Copy link
Contributor Author

Bump, see question above.

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants